SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-1.fc9.src.rpm Context Free is a program that generates images from written instructions called a grammar. The program follows the instructions in a few seconds to create images that can contain millions of shapes.
I note the proper compiler flags aren't used; most things seem to be compiled with -Isrc-common -Isrc-unix -Iobjs -Isrc-agg/include -Isrc-common/agg-extras -O3 -c There seems to be the occasional cc call, probably from yacc, that includes the regular optflags plus all of the above. That's probably why the debuginfo package includes only the yacc-generated bits. There are also several patches included; it would be good to get comments including at least their upstream status.
Patches sent upstream (for gcc43 compat), except for the nostrip patch. Can you suggest a way to enforce the proper compiler flags? I've played around with setting CFLAGS and CPPFLAGS and not having much success.
> Patches sent upstream (for gcc43 compat), except for the nostrip patch. Please document that in the spec. See http://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus > Can you suggest a way to enforce the proper compiler flags? Patch the CPPFLAGS define in the Makefile, perhaps? Also, does this package include its own version of agg? I think agg is already in the distro. If that's the case, this package should use the system version.
Still playing with the compiler flags. Just got confirmation from upstream that cfdg needs the bundled agg to run, as upstream agg has thusfar been unresponsive to their patches.
@Jon Any updates regarding flags ? This request is stalled for long and needs an update soon.
Not so far. Life intervened a bit, I'll keep playing with it.
SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-2.fc9.src.rpm This seems better.
Still build optflags issue and mktemp issue: http://koji.fedoraproject.org/koji/getfile?taskID=880082&name=build.log full koji ref: http://koji.fedoraproject.org/koji/taskinfo?taskID=880079
Patched for the mktemp issue, still at a loss as to how to correct the optflags issue. Any suggestions? SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-3.fc9.src.rpm
Add this patch: --- ContextFreeSource2.1.orig/Makefile 2007-04-29 07:51:20.000000000 +0200 +++ ContextFreeSource2.1/Makefile 2008-10-14 23:12:11.000000000 +0200 @@ -102,8 +102,9 @@ # Rules # +OPTFLAGS = -03 CPPFLAGS += $(patsubst %,-I%,$(INC_DIRS)) -CPPFLAGS += -O3 +CPPFLAGS += $(OPTFLAGS) #CPPFLAGS += -ggdb $(OBJ_DIR)/%.o : %.cpp Aand change make CFLAGS+="$RPM_OPT_FLAGS" to make OPTFLAGS="%{optflags}" BTW: don't mix $ style and % style macros. This mkdir -p %{buildroot}%{_bindir} install -m 755 cfdg %{buildroot}%{_bindir}/cfdg could be one line: install -D -m 755 cfdg %{buildroot}%{_bindir}/cfdg Add smp_flags to make. Very picky: -create. should be - Create. http://www.contextfreeart.org/index.html -> http://www.contextfreeart.org/
Wow, thanks, your suggestions are more details than some people's instructions. :) SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-4.fc9.src.rpm All addressed/applied.
Review Guidelines MUST items: - [OK] rpmlint output: - [OK] package name - [OK] %{name}.spec - [OK] Packaging Guidelines - [-] Licensing Guidelines GPLv2+ is correct, however some files: src-common/test* are under Academic Free License version 2.0 Comment? Contact upstream. - [OK] License Field in spec - [-] License text in %doc Seems like LICENSE.txt is missing the "and later" which is present in files. - [OK] Spec file in en_US - [OK] legible spec file - [OK] source matches upstream md5sum ContextFreeSource2.1.tgz* 477242e74c4f953ceca7bf06e944a46e ContextFreeSource2.1.tgz 477242e74c4f953ceca7bf06e944a46e ContextFreeSource2.1.tgz.rpm - [OK] compiles successfully http://koji.fedoraproject.org/koji/taskinfo?taskID=889881 - N/A %find_lang - N/A shared libs - N/A not relocatable - [OK] directory ownership - [OK] no duplicate files in %files - [OK] proper permissions on files, %defattr present - [OK] %clean section cleans %{buildroot} - [OK] consistently uses macros - [OK] package contains code - N/A large docs - [OK] %doc files do not affect runtime behaviour - N/A header files in -devel - N/A static libs in -static - N/A foo.pc files - N/A libfoo.so.1.1 - N/A no devel package - N/A no .la archives - N/A desktop file - [OK] Does not own files/dirs owned by other packages - [OK] %install cleans out %{buildroot} first - [OK] all filenames are valid ASCII and thus UTF-8 - N/A Scriptlets Summary: everything seems fine except some licenses issues: - a lot of files are missing license headers - there are at least two licenses here GPLv2+ and Academic Free License version 2.0 - LICENSE.txt seems to be GPLv2. I would recommend to contact upstream about these issues. Pedantic: - remove extra space in version and release tag.
Actually, it was my understanding that not all files must have license headers, nor must LICENSE.txt include 'and later. I'll check on the Academic Free License bits.
It's not a blocker, however it would be nice of upstream fixed it.
I'm actually in conversation with them how. They'll be re-licensing those bits GPLv2+ as well, I'm waiting to hear when the release with this well be.
These licenses issues tend to show up in Fedora reviews, it takes time and a bit of pain, however in the long run we are making the world a better place. Thanks for your contribution!
(In reply to comment #16) > These licenses issues tend to show up in Fedora reviews, it takes time and a > bit of pain, however in the long run we are making the world a better place. > +1
Next release, with this correction, will be in +-1 month. Should we go ahead with a modified tarball, or wait for the new release?
Sorry for delay. It's up to you, you decide.
I'm happy with a modified tarball: SPEC: http://zanoni.jcomserv.net/fedora/cfdg/cfdg.spec SRPM: http://zanoni.jcomserv.net/fedora/cfdg/cfdg-2.1-5.fc9.src.rpm
Great, I can't find any issues with the update package: APPROVED
Thanks! New Package CVS Request ======================= Package Name: cfdg Short Description: Context Free Design Grammar Owners: limb Branches: F-9 InitialCC:
CVS Done
cfdg-2.1-5.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/cfdg-2.1-5.fc9
cfdg-2.1-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.