Bug 452150 - Review Request: swarp - Tool that resamples and co-adds together FITS images
Review Request: swarp - Tool that resamples and co-adds together FITS images
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-06-19 12:50 EDT by Sergio Pascual
Modified: 2008-06-20 13:54 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-06-20 13:54:06 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Sergio Pascual 2008-06-19 12:50:48 EDT
Spec URL: http://sergiopr.fedorapeople.org/swarp.spec
SRPM URL: http://sergiopr.fedorapeople.org/swarp-2.17.1-1.fc9.src.rpm
Description: SWarp is a program that resamples and co-adds together FITS images 
using any arbitrary astrometric projection defined in the WCS standard.
Comment 1 Jason Tibbitts 2008-06-19 22:03:10 EDT
Two observations:

The pdf file is 1.5MB and three times the size of the rest of the package.  Did
you consider putting it in a separate package?   I don't think it's a
requirement but you know best how this package will be used.

%{__mkdir_p} %{buildroot}%{_datadir}/%{name} at the end of %install seems to be
superfluous, as that directory is created (and swarp.xsl is installed there) by
the install process.  It seems to be harmless, though.

I don't think either of these are blockers, though.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
 build root is OK.
 license field matches the actual license.
 license is open source-compatible.
 license text not included upstream.
 license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   swarp = 2.17.1-1.fc10
   (no non-glibc dependencies)
* %check is not present; no test suite upstream.  There is a test directory 
  containing one fits file, but it's not immediately clear what should be done 
  with it.  I ran the executable and gave it the test file and it did... 
  something, without crashing, and didn't complain about it.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
? documentation is 3x the rest of the package.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

Comment 2 Sergio Pascual 2008-06-20 02:40:02 EDT
Thanks, I will separate docs in the next release of the package

New Package CVS Request
Package Name: swarp
Short Description: Tool that resamples and co-adds together FITS images
Owners: sergiopr
Branches: F-8 F-9
Cvsextras Commits: yes
Comment 3 Kevin Fenzi 2008-06-20 11:28:25 EDT
cvs done.
Comment 4 Sergio Pascual 2008-06-20 13:54:06 EDT
Built in rawhide

Note You need to log in before you can comment on or make changes to this bug.