Bug 452282 - Review Request: mfiler3 - Two pane file manager under UNIX console
Review Request: mfiler3 - Two pane file manager under UNIX console
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-20 14:05 EDT by Mamoru TASAKA
Modified: 2008-06-21 13:32 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-21 13:32:50 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Mamoru TASAKA 2008-06-20 14:05:49 EDT
Spec URL: http://mtasaka.fedorapeople.org/Review_request/mfiler3/mfiler3.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/mfiler3/mfiler3-1.0.0-1.fc9p.src.rpm
Description: 
Minnu's Filer3 is a two pane file manager under UNIX console.

koji scratch build
for dist-f10
http://koji.fedoraproject.org/koji/taskinfo?taskID=673171
for dist-f9-updates-candidate
http://koji.fedoraproject.org/koji/taskinfo?taskID=673235

rpmlint:
mfiler3.i386: E: zero-length /usr/share/doc/mfiler3-1.0.0/doc/BUG
mfiler3.i386: W: hidden-file-or-dir /etc/mfiler3/.mfiler3

For first rpmlint:
I added the whole directory doc/ as %doc, so while it is easy to remove
this rpmlint I want to leave this for now.
For second rpmlint: we can safely ignore this rpmlint.

Note:
mfiler3 makefile does not support "make install DESTDIR=foo" format.
Comment 1 Jason Tibbitts 2008-06-20 15:23:11 EDT
Re: the rpmlint warnings, I also get 
  mfiler3-mdnd.x86_64: W: no-documentation
which isn't a problem.

I would probably delete the zero-length BUG file in %prep to avoid complicating
the %files list, but I don't see it as a particularly significant problem.

My Japanese is just good enough to puzzle out most of the homepage, and most of
it is gairaigo anyway.  One thing I couldn't quite get is the "bug" section
mentioning, I think, excessive memory consumption.  Maybe that's what should be
in the BUG file.

I think I'll have to take your word on the license; I don't see any mention of
the GPL version anywhere, but there are some non-ASCII comments in the source
which don't render in UTF8 for me.  I guess it's conceivable that there's
something in there, though I don't think it likely.

* source files match upstream:
  6d22b511a3279764c357b4355ac1c9b21354338b52e8d7eb0c47f5c50783db06  
   mfiler3-1.0.0.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  mfiler3-1.0.0-1.fc10.x86_64.rpm
   config(mfiler3) = 1.0.0-1.fc10
   mfiler3 = 1.0.0-1.fc10
  =
   /bin/bash
   config(mfiler3) = 1.0.0-1.fc10
   libgc.so.1()(64bit)
   libmigemo.so.1()(64bit)
   libncurses.so.5()(64bit)
   libonig.so.2()(64bit)
   libtinfo.so.5()(64bit)

  mfiler3-mdnd-1.0.0-1.fc10.x86_64.rpm
   mfiler3-mdnd = 1.0.0-1.fc10
  =
   /usr/bin/env
   mfiler3 = 1.0.0-1.fc10
   ruby(gtk2)

* %check is not present; no test suite upstream.  It seems to run fine although 
   I didn't try to do much with it.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED
Comment 2 Mamoru TASAKA 2008-06-20 20:21:52 EDT
Thank you for your quick review!

New Package CVS Request
=======================
Package Name:      mfiler3
Short Description: Two pane file manager under UNIX console
Owners:            mtasaka
Branches:          F-9 F-8
InitialCC: 
Cvsextras Commits: yes
Comment 3 Kevin Fenzi 2008-06-21 11:32:27 EDT
cvs done.
Comment 4 Mamoru TASAKA 2008-06-21 13:32:50 EDT
Rebuilt successfully on devel F-9/8, requested for F-9/8 on bodhi, closing.
Thank you for the review and CVS procedure (closed within one day !)

Note You need to log in before you can comment on or make changes to this bug.