Spec URL: http://rydzyk.net/fedora/netris.spec SRPM URL: http://rydzyk.net/fedora/netris-0.52-3.fc9.src.rpm Description: Netris is a curses-based Tetris clone. It has single player and internet game (2 player) modes. You can also play against a bot. I need a sponsor, because it is my first package.
My understanding is that we can't package Teris clones, especially if we actually go so far as to call them "Tetris clones". Asking the legal folks for advice.
As far as I know, there is a company, which holds "Tetris" trademark, but they do not own anything else (like patents, look and feel...). Because of that, upstream describes this game "version of T*tris", anyway, this is only description, so I thought it wouldn't make any problems. Also, there are some clones already packaged, like ksirtet from kdegames3. Anyway, thank you for help. I know there are some rules here.
The clone is not the problem, the trademark is. The name of the game cannot use the registered "Tetris" trademark, or anything similar to it. "Netris" is far too similar to "Tetris", as would be "T*tris" or anything which rhymes with "Tetris". As is, this package is not acceptable for Fedora, however you can make it acceptable by renaming the game so that it does not violate the trademark, and minimizing the use of the "Tetris" mark to nominative use (basically, you can say that "$FOO is a puzzle game similar to Tetris (tm)"). You cannot call it a "Tetris clone". You could rename the game to something like NetFallingBlocks, NetBlockPuzzle, or anything else really, as long as it doesn't infringe upon the "Tetris" mark. You would need to be sure that the rename occurs in all user visible places (anything a user might be able to see while playing the game). You would not need to rename internal functions or the actual binary executable. The RPM name would need to change. If you have questions, please let me know.
Thank you for reply. I have chosen "netblocks" as the new name. At the moment I'm patching documentation. Do I have to include some copyright information about Tetris if I say "similar to Tetris (tm)"?
Have you perhaps seen http://savannah.nongnu.org/projects/netblocks ?
I saw that, but there weren't any releases. I looked at their SVN and it was empty. Now, after a longer investigation I have found http://games.court-empty. Now, after a longer investigation I have found http://games.court-jus.net/netblocks#attachments . It seems like I need to find another name.
Finally, I think everything in docs and software is renamed. Spec URL: http://rydzyk.net/fedora/netblox.spec SRPM URL: http://rydzyk.net/fedora/netblox-0.52-4.fc9.src.rpm
Lifting FE-Legal, there is no longer a trademark issue here.
rpmlint clean. Drop the explicit ncurses Requires, rpm will do it automatically. Despite being a console app, this could benefit from a .desktop file, see bombardier. netblox -R mentions the Forbidden Proper Noun. Probably should be patched to be more general, but it's your call, as Spot did indeed lift the Legal flag. Spot is still free to correct me on this, however. Mock build fails. Patch #7 (netris-0.52-pysiak1.diff): + /bin/cat /builddir/build/SOURCES/netris-0.52-pysiak1.diff + /usr/bin/patch -s -p1 --fuzz=0 4 out of 6 hunks FAILED -- saving rejects to file game.c.rej 1 out of 1 hunk FAILED -- saving rejects to file inet.c.rej RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.rqp5dT (%prep) Bad exit status from /var/tmp/rpm-tmp.rqp5dT (%prep) Child returncode was: 1 EXCEPTION: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/netblox.spec'] Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/mock/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.5/site-packages/mock/util.py", line 316, in do raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode) Error: Command failed. See logs for output. # ['bash', '--login', '-c', 'rpmbuild -bb --target i386 --nodeps builddir/build/SPECS/netblox.spec'] LEAVE do --> EXCEPTION RAISED You should either re-diff the patch, or put this at the beginning of the spec as a temporary workaround: %define _default_patch_fuzz 2 Honestly, re-diffing would be better. Once fixed, mock builds are fine, no BuildRequire issues. Other than the Requires and patch fuzz issue, there are really no blockers after a full review. Since I see you need a sponsor, please do a few practice reviews and post links here. Once that's done satisfactorily, I'd be willing to sponsor you.
Ping?
Whoops, I'm sorry, I had misconfigured my gmail filters, so I didn't receive notification about your message. The patch was rejected due to the earlier rpm behaviour and guidelines, that allowed fuzzy patches. I'm going to release updated package later today.
Sounds good. Thanks!
Spec URL: http://rydzyk.net/fedora/netblox.spec SRPM URL: http://rydzyk.net/fedora/netblox-0.52-6.fc10.src.rpm BTW. my rename patch renames T*tris to Tetris(tm) in order for it to look better. Spot said above, that the package can't be "Tetris" or "Tetris clone", but it can be "similar to Tetris".
If you're going to do this, don't use (R) or (TM). Instead, have a line that says: "Tetris is a registered trademark of The Tetris Company."
(In reply to comment #14) > If you're going to do this, don't use (R) or (TM). I know this is slightly different from what I said back in 2008, but Red Hat Legal has adjusted their advice about the use of trademark symbols since then.
I've addressed these issues in the new release. Spec URL: http://rydzyk.net/fedora/netblox.spec SRPM URL: http://rydzyk.net/fedora/netblox-0.52-7.fc10.src.rpm
Looks better, only two things. 1. Drop the explicit ncurses Requires. 2. I don't see the icon in my menus. Is it placed properly? Since you're this close, it's probably a good time to start those practice reviews.
My first practice review: https://bugzilla.redhat.com/show_bug.cgi?id=494171 The icon is in compressed SVG format and your desktop environment might not support it (I'm using only KDE, that's why I didn't spot this), so I'm going to rasterize it in the next release.
I'm using GNOME, but it's best to use something as many as possible can use. PNG would probably be best.
See comments on 494171.
Spec URL: http://rydzyk.net/fedora/netblox.spec SRPM URL: http://rydzyk.net/fedora/netblox-0.52-8.fc10.src.rpm Changelog: - Drop explicit ncurses requirement - Rasterize icon
Much better. Just a couple more practice reviews and we're on our way.
OK, my next review: https://bugzilla.redhat.com/show_bug.cgi?id=489728
See comments on 489728.
Closing, non-responsive submitter. Please re-open if still interested.