Red Hat Bugzilla – Bug 452577
Actual & placeholder funcs have differing param counts
Last modified: 2009-01-20 15:25:41 EST
Description of problem:
Function xfrm_audit_state_replay(a, b, c) in ~/include/net/xfrm.h is replaced bu
a macro of the same name if the Auditd System Calls feature is not enabled. The
probalem is that the macro is defined as having 4, not 3, parameters. The code
that invokes this func/macro only provides 3 parameters.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Disable the Auditd System Calls feature in the kernel
2. Attempt to rebuild the kernel
net/ipv4/xfrm4_input.c:98:39: error: macro "xfrm_audit_state_replay" requires 4
arguments, but only 3 given
net/ipv4/xfrm4_input.c: In function ‘xfrm4_rcv_encap’:
net/ipv4/xfrm4_input.c:98: error: ‘xfrm_audit_state_replay’ undeclared (first
use in this function)
net/ipv4/xfrm4_input.c:98: error: (Each undeclared identifier is reported only once
net/ipv4/xfrm4_input.c:98: error: for each function it appears in.)
make: *** [net/ipv4/xfrm4_input.o] Error 1
make: *** [net/ipv4] Error 2
make: *** [net] Error 2
Placeholder macro should be defined as having the same number of parameters as
the function it is replacing.
Same param count mismatch is also seen with function/macro
xfrm_naudit_state_replay() in same header file.
Created attachment 310071 [details]
Change 4-param macros to match 3-param functions
Red Hat does not support custom kernel building. However, custom kernels should
still build :)
Thanks Steve -- I'll see what I can do about getting this into 5.3.
Created attachment 310158 [details]
RHEL5 fix for this issue
Loosely based on original patch -- now fixes compile errors and warning.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release. Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update
You can download this test kernel from http://people.redhat.com/dzickus/el5
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.