Bug 453171 - kernel: usbhid: probe of 3-1:1.0 failed with error -5
Summary: kernel: usbhid: probe of 3-1:1.0 failed with error -5
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: kernel
Version: 4.8
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Aristeu Rozanski
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-27 17:28 UTC by Ben Levenson
Modified: 2009-05-18 19:35 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-18 19:35:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
test patch (1.14 KB, patch)
2008-09-03 20:44 UTC, Aristeu Rozanski
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:1024 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 4.8 kernel security and bug fix update 2009-05-18 14:57:26 UTC

Description Ben Levenson 2008-06-27 17:28:07 UTC
Description of problem:
The following appears in /var/log/messages when connecting and disconnecting a
wacom tablet:

Jun 27 12:17:14  kernel: usb 3-1: new low speed USB device using address 5
Jun 27 12:17:14  kernel: usbhid: probe of 3-1:1.0 failed with error -5
Jun 27 12:17:15  kernel: input: Wacom Graphire4 4x5 on usb-0000:00:1d.2-1

Everything is working as expected, but the error message is a little disturbing.

Version-Release number of selected component (if applicable):
kernel-2.6.9-75.EL

How reproducible:
100%

Additional info:
related to: https://bugzilla.redhat.com/show_bug.cgi?id=161241

Comment 1 Aristeu Rozanski 2008-09-03 20:43:47 UTC
The problem is at:
static struct hid_device *usb_hid_configure(struct usb_interface *intf)
{       
        struct usb_host_interface *interface = intf->cur_altsetting;
        struct usb_device *dev = interface_to_usbdev (intf);
        struct hid_descriptor *hdesc;
        struct hid_device *hid;
        unsigned quirks = 0, rsize = 0;
        char *buf, *rdesc;
        int n;
        
        /* Ignore all Wacom devices */
        if (dev->descriptor.idVendor == USB_VENDOR_ID_WACOM)
                return NULL;
static int hid_probe (struct usb_interface *intf, const struct usb_device_id *id)
{       
        struct hid_device *hid;
        char path[64];
        int i;
        char *c;
        
        dbg("HID probe called for ifnum %d",
                        intf->altsetting->desc.bInterfaceNumber);

        if (!(hid = usb_hid_configure(intf)))
                return -EIO;

hid_probe() shouldn't return -EIO in this case, -ENODEV would be more
appropriate and it'd prevent for the message to be printed.

It's fixed on 479f6ea85e513551510ad52f37e69e1c596ad356

RHEL-4 patch will follow

Comment 2 Aristeu Rozanski 2008-09-03 20:44:27 UTC
Created attachment 315687 [details]
test patch

Comment 3 RHEL Program Management 2009-03-03 14:30:46 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 7 Vivek Goyal 2009-03-11 14:09:45 UTC
Committed in 83.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/

Comment 10 errata-xmlrpc 2009-05-18 19:35:33 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1024.html


Note You need to log in before you can comment on or make changes to this bug.