Bug 454020 - Review Request: tcl-zlib - Tcl extension for zlib support
Review Request: tcl-zlib - Tcl extension for zlib support
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marcela Mašláňová
Fedora Extras Quality Assurance
:
Depends On:
Blocks: 454022
  Show dependency treegraph
 
Reported: 2008-07-03 16:21 EDT by Tom "spot" Callaway
Modified: 2009-01-12 11:50 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-12 11:50:08 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmaslano: fedora‑review+
tcallawa: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2008-07-03 16:21:25 EDT
Spec URL: http://auroralinux.org/people/spot/review/coccinella/tcl-zlib.spec
SRPM URL: http://auroralinux.org/people/spot/review/coccinella/tcl-zlib-2.0.1-0.1.svn40.fc10.src.rpm
Description: 
This is extension is a standalone version of the tclkit [zlib]
command/extension. See http://wiki.tcl.tk/zlib for command syntax.
Comment 1 Marcela Mašláňová 2008-10-23 04:52:15 EDT
FAIL source files match upstream: 
can't download from svn without account
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
OK license field MIT matches the actual license.
OK license is open source-compatible. License text not included upstream.
FAIL latest version is being packaged.
can't say
OK BuildRequires are proper.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
tcl-zlib-devel.x86_64: W: no-documentation, but that's ok. No documentation at all provided.
OK final provides and requires look sane.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.

How can I check the source?
Comment 2 Tom "spot" Callaway 2009-01-06 11:56:42 EST
So, upstream has gone down since I grabbed the tarball. I emailed him, and he said he would put the svn server back up, but he has still not done so (and has not responded to any of my many additional emails). He did say in his initial email that he was focusing his efforts on adding zlib support to the next release of tcl.

I suppose you can either trust me on the code, or not. :)
Comment 3 Marcela Mašláňová 2009-01-12 01:39:11 EST
I don't want block this review for other dependent packages.
APPROVED
Comment 4 Tom "spot" Callaway 2009-01-12 11:18:38 EST
New Package CVS Request
=======================
Package Name: tcl-zlib
Short Description: Tcl extension for zlib support
Owners: spot
Branches: F-9 F-10 devel
InitialCC: 

... and it's done.
Comment 5 Tom "spot" Callaway 2009-01-12 11:50:08 EST
Built for F-9, F-10, devel. Thanks for your patience on this one.

Note You need to log in before you can comment on or make changes to this bug.