Bug 454199 - Review Request: pentaho-libxml - Namespace aware SAX-Parser utility library
Summary: Review Request: pentaho-libxml - Namespace aware SAX-Parser utility library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Colin Walters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 457263
TreeView+ depends on / blocked
 
Reported: 2008-07-06 14:16 UTC by Caolan McNamara
Modified: 2008-08-12 01:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-06 18:00:20 UTC
Type: ---
walters: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2008-07-06 14:16:12 UTC
Spec URL: http://people.redhat.com/caolanm/jfreereport/pentaho-libxml.spec
SRPM URL: http://people.redhat.com/caolanm/jfreereport/pentaho-libxml-0.9.11-1.fc9.src.rpm
Description: Java Namespace aware SAX-Parser utility library

This is a dependency of pentaho-reporting-flow-engine (formerly known as jfreereport) which itself is a dependency of OpenOffice.org3. This package is known as "libxml" by pentaho but that name is already in use in fedora, hence the suggested pentaho-libxml

Comment 1 Colin Walters 2008-08-06 14:55:15 UTC
[+] source files match upstream
[+] package meets naming and versioning guidelines
 - Can you annotate the patch to say whether it is going to be upstreamed?  
 https://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus 

[+] specfile is properly named, is cleanly written and uses macros consistently
[+] dist tag is present.
[+] build root is correct.
 (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the
recommended value, but not the only one)
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] license text included in package.
[+] latest version is being packaged (as far as I can tell)
[+] BuildRequires are proper
[+] %clean is present.
[+] package builds in koji
[+] package installs properly
[+] rpmlint is silent.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] code, not content.
[+] -javadoc package exists and works
[+] %doc exists

Looks good to me.

Comment 2 Caolan McNamara 2008-08-06 15:13:20 UTC
New Package CVS Request
=======================
Package Name: pentaho-libxml
Short Description:  Namespace aware Java SAX-Parser utility library
Owners: caolanm
Branches:
InitialCC:
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-08-06 17:30:50 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.