Bug 454364 - libSAD API headers are broken
libSAD API headers are broken
Product: Fedora
Classification: Fedora
Component: audacious (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: Ralf Ertzinger
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks: 453026 465081
  Show dependency treegraph
Reported: 2008-07-07 19:33 EDT by Michael Schwendt
Modified: 2008-10-16 08:06 EDT (History)
1 user (show)

See Also:
Fixed In Version: audacious-1.5.1-3
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-10-16 08:06:32 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Michael Schwendt 2008-07-07 19:33:00 EDT

libSAD header common.h evaluates external autoconf
macros (here HAVE_CONFIG_H) and tries to include a
non-existant config.h header. Something like that
does not belong into a library API. As reported 
in FTBFS summary on fedora-devel:

In file included from /usr/include/libSAD/libSAD.h:23
                 from /usr/include/audacious/util.h:41
                 from configure.c:2
config.h: No such file or directory
Comment 1 Ralf Ertzinger 2008-08-21 15:20:17 EDT
Those files are not meant to be installed for the 1.5 release, I'll drop them as soon as the build sys works again
Comment 2 Michael Schwendt 2008-09-24 11:27:51 EDT
util.h:#include "libSAD/libSAD.h"
Comment 3 Dominik 'Rathann' Mierzejewski 2008-10-13 14:37:26 EDT
And, to give a real example of breakage after libSAD.h is removed:

In file included from audacious.c:19:
/usr/include/audacious/util.h:41:27: error: libSAD/libSAD.h: No such file or directory
In file included from audacious.c:19:
/usr/include/audacious/util.h:94: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sadfmt_from_afmt'

This is from xmp build (bug 453026).
Comment 4 Michael Schwendt 2008-10-16 08:06:32 EDT
Just built audacious-plugin-fc in rawhide without errors.

Note You need to log in before you can comment on or make changes to this bug.