Sitecopy allows you to easily maintain remote Web sites. The program
will upload files to the server which have changed locally, and delete
files from the server which have been removed locally, to keep the
remote site synchronized with the local site, with a single
command. sitecopy will also optionally try to spot files you move
locally, and move them remotely. FTP and WebDAV servers are
SPEC FILE: http://rakesh.gnulinuxcentar.org/sitecopy.spec
This is my fifth package review submission and I am looking for sponsor.
I'd be happy to review this. Look for a full review a bit later today...
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
See below - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version
1. The License tag here should be:
as far as I can see. All the source files say "or any later version".
2. From the build output:
checking for neon-config... none
configure: no external neon library found
configure: using bundled neon (0.26.0)
You seem to be missing a 'BuildRequires: neon-devel' ?
configure: zlib not supported
configure: SSL support is not enabled
zlib-devel and openssl-devel ?
There might also be some gettext or the like BuildRequires missing, as
Internationalization: Built using native support
2. neon-devel - fixed
internationalization - fixed
openssl-devel - fixed
There are two messages:
configure: zlib not supported
configure: Thread-safe SSL not supported
"zlib not supported" - From Changelog & configure script it looks like zlib
code was breaking and they have disabled its use and bypassing functions. I
will try to confirm by digging further today.
Letest release today solves these messages:
I have updated to latest release.
That does indeed solve all the issues I see, so this package is APPROVED.
I have sponsored you, so you should continue the process at:
for this and your other approved package.
Please let me know via email or irc if I can assist you any with the process...
New Package CVS Request
Package Name: sitecopy
Short Description: Tool for easily maintaining remote web sites
Branches: F-8 F-9
Cvsextras Commits: yes
sitecopy-0.16.5-1.fc8 has been submitted as an update for Fedora 8
sitecopy-0.16.5-1.fc9 has been submitted as an update for Fedora 9
sitecopy-0.16.5-1.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update sitecopy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-6541
sitecopy-0.16.5-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
sitecopy-0.16.5-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.