Spec URL: http://jesusfreak91.googlepages.com/nxt_python.spec SRPM URL: http://jesusfreak91.googlepages.com/nxt_python-0.7-1.fc9.src.rpm Description: nxt_python is a package for controlling a LEGO NXT robot using the python programming language. It can communicate with the robot via either bluetooth or usb (usb requires adding the user to the group 'lego').
Hum .. source0 seems plain wrong. Why not using the one from the project's site, http://home.comcast.net/~dplau/nxt_python/download/nxt_python-0.7.tar.gz ? Not to mention that the file bundled in the src.rpm is different than the one specified now in %source. python as a BR is redundant, python-devel will bring it in. Creating a specific group should follow the guidelines available at https://fedoraproject.org/wiki/Packaging/UsersAndGroups. Mind the "We never remove users or groups created by packages." line. rpmlint also complains about that (nxt_python.noarch: W: dangerous-command-in-%postun groupdel) Otherwise things seem pretty OK.
Those problems should now be fixed, and the spec and srpm files updated.
Please increment the release tag each time you modify the spec, add an entry to the changelog briefly describing the modifications and post the new URLs over here. The changelog is mandatory for packages already in CVS but following the same rule while the package is submitted for review helps both in tracking modifications over time as well as developing a habit.
Alright, I've done that. I should have remembered in the first place, but it's a habit I'm still working on forming. new srpm: http://jesusfreak91.googlepages.com/nxt_python-0.7-2.fc9.src.rpm
Well, for 0.7-2: * SourceURL - Please use %name, %version macros. With using these macros perhaps you won't have to modify SourceURL when the version is upgraded. * %PATCH0 - I guess there is no needed to rename "COPYING" to "LICENSE". Please use COPYING file as it is. * Requires - Please check if all needed rpms are correctly added to Requires. At least "pygtk2" seems needed for Requires as %_bindir/nxt_python contains: ----------------------------------------------------------- 16 import cStringIO 17 import gtk 18 import os.path ----------------------------------------------------------- ! Note I usually check python module related Requires like below: ----------------------------------------------------------- $ grep -h 'import ' `rpm -ql nxt_python | grep -v /usr/share/doc` | sort | uniq ----------------------------------------------------------- * Udev rule config file - It seems that usually udev rule config files are not marked as (noreplace) (even if rpmlint warns about it)
Alright, those should be fixed. new srpm: http://jesusfreak91.googlepages.com/nxt_python-0.7-3.fc9.src.rpm
Okay. ----------------------------------------------------------------- This package (nxt_python) is APPROVED by mtasaka -----------------------------------------------------------------
New Package CVS Request ======================= Package Name: nxt_python Short Description: Lego Mindstorms NXT Control Package Owners: mcleanj Branches: F-8 F-9 InitialCC: mcleanj Cvsextras Commits: yes
cvs done.
Please sumbit a request to push the rebuilt packages into F-9/8 repositories on bodhi then close this bug as NEXTRELEASE.