Spec URL: http://jesusfreak91.googlepages.com/figlet.spec SRPM URL: http://jesusfreak91.googlepages.com/figlet-2.2.2-1.fc9.src.rpm Description: figlet is run on the cli and takes stdin and prints it out as ASCIIart. Figlet supports several options concerning output width/justification. Figlet also supports several fonts, which can be shown using the 'showfigfont' and 'figlist' commands.
Note to anyone who might notice that this was submitted (and withdrawn) previously: the code was relicensed from the (not acceptable) Artistic license to the (perfectly acceptable) Academic Free License in 2005.
*** Bug 251857 has been marked as a duplicate of this bug. ***
I am not a sponsor. These are few suggestions: 1. No need for buildRequires: autoconf, automake, libtool, glibc 2. Source Link (or package source) should be from project download resources: ftp://ftp.figlet.org/pub/figlet/program/unix/ seems to be right place. 3. For making Source URL you may use Adam Jackson's trick: %define figversion %( echo %{version} | sed 's/\\.//g' ) ftp://ftp.figlet.org/pub/figlet/program/unix/%{name}%{figversion}.tar.gz 4. package does not own %{_datadir}/figlet directory use %{_mandir}/man6/figlet.6* %{_datadir}/figlet
I've fixed these problems and uploaded the changes.
It is very required that for changes you should update URLs to new srpm and spec, increment in release count. So update changelog and release field and post newly build srpm and spec file URLs
As soon as you do so I can just help with a detailed pre-review, to help you :-) I am not a sponsor so cannot review officially until you are sponsored. You may like to check wiki entry for 'HowToGetSponsored'
Alright. The spec file is the same url. the srpm is now: http://jesusfreak91.googlepages.com/figlet-2.2.2-2.fc9.src.rpm
There are a couple of fixes needed: 1) According to the following section of the build log: + make -j5 gcc -g -DDEFAULTFONTDIR=\"/usr/share/figlet\" \ -DDEFAULTFONTFILE=\"standard.flf\" \ figlet.c zipio.c crc.c inflate.c -o figlet gcc -g -o chkfont chkfont.c chkfont.c: In function 'my_alloc': chkfont.c:68: warning: incompatible implicit declaration of built-in function 'malloc' chkfont.c: In function 'usageerr': chkfont.c:103: warning: incompatible implicit declaration of built-in function 'exit' chkfont.c: In function 'checkit': chkfont.c:226: warning: incompatible implicit declaration of built-in function 'exit' chkfont.c:260: warning: incompatible implicit declaration of built-in function 'free' chkfont.c: In function 'main': chkfont.c:458: warning: incompatible implicit declaration of built-in function 'free' chkfont.c:460: warning: incompatible implicit declaration of built-in function 'exit' the default compiler flags setup by the buildsystem are ignored. Please fix the spec to use them 2) INSTALL="install -p" is ignored. "make install" uses a plain cp (rather than $INSTALL) which does not preserve timestamps. Please try to fix that, too. 3) the changelog contains a reference to "%files". Please use "%%files" instead (this will make rpmlint happier)
Those problems should be fixed now. new srpm: http://jesusfreak91.googlepages.com/figlet-2.2.2-3.fc9.src.rpm
As debian says, currently I think that this is non-free. The license of crc.c (and others): http://packages.debian.org/changelogs/pool/non-free/f/figlet/figlet_2.2.2-1/figlet.copyright The issue http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=274950 does not seem to have disappeared. Blocking FE-Legal.
Figlet has been re-licensed (in 2005) under the Academic Free License, rather than the Artistic license. See comment #1.
No. You are just saying that the license text is changed from ASL to AFL. Yes, actually with this license change figlet.c is relicensed under from ASL to AFL But I am referring to the license used in crc.c, inflate.c, and so on. The license used in these codes are not ASL and not AFL. They are licensed under what debian regards as non-free and I agree with this (i.e. these codes are non-free).
Ah. That is a problem. In that case, then I suppose I should mark it as closed?
Okay. Once closing. Thank you anyway.
*** This bug has been marked as a duplicate of bug 820642 ***