Bug 454985 - Review Request: hunspell-sr - Serbian hunspell dictionaries
Summary: Review Request: hunspell-sr - Serbian hunspell dictionaries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-07-11 10:15 UTC by Caolan McNamara
Modified: 2008-07-23 17:43 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-07-23 17:43:59 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2008-07-11 10:15:46 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hunspell-sr.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hunspell-sr-0.20080711-1.fc9.src.rpm
Description: Serbian Hunspell dictionaries as used by OpenOffice.org/firefox/et. al.

Comment 1 Caolan McNamara 2008-07-11 10:16:30 UTC
rpmlint is silent

Comment 2 Parag AN(पराग) 2008-07-23 08:20:27 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733452
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
11faca5e15bb64b60ffa1910f6ced975  MySpell-sr_YU-and-sh_YU.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are honoured correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.


Comment 3 Caolan McNamara 2008-07-23 08:32:23 UTC
New Package CVS Request
=======================
Package Name: hunspell-sr
Short Description: Serbian hunspell dictionaries
Owners: caolanm
Branches: F-9
InitialCC:
Cvsextras Commits: yes


Comment 4 Kevin Fenzi 2008-07-23 15:54:49 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.