Spec URL: http://cwickert.fedorapeople.org/review/xfce4-mpc-plugin.spec SRPM URL: http://cwickert.fedorapeople.org/review/xfce4-mpc-plugin-0.3.3-1.fc10.src.rpm Description: A simple client plugin for MPD, the Music Player Daemon.
I would be happy to review this. Look for a full review in a bit.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License (BSD) See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b4f7f67589f34f77973a51dd5069712d xfce4-mpc-plugin-0.3.3.tar.gz b4f7f67589f34f77973a51dd5069712d xfce4-mpc-plugin-0.3.3.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version Issues: 1. Is the License tag here really BSD? I think it should be "ISC" http://www.isc.org/index.pl?/sw/dhcp/dhcp-copyright.php (well, it's ISC style)
Yes, it's ISC but not BSD. Can I change that after import or do you want me to do it now?
When you import is fine with me. I don't see any other issues, so this is APPROVED.
New Package CVS Request ======================= Package Name: xfce4-mpc-plugin Short Description: MPD client for the Xfce panel Owners: cwickert Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
cvs done.
xfce4-mpc-plugin-0.3.3-1.fc9 has been submitted as an update for Fedora 9
xfce4-mpc-plugin-0.3.3-1.fc8 has been submitted as an update for Fedora 8
Thanks for the review, Kevin. If you want to do another bug #455083 is still left. ;)
xfce4-mpc-plugin-0.3.3-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
xfce4-mpc-plugin-0.3.3-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: xfce4-mpc-plugin New Branches: epel7 Owners: cwickert nonamedotc InitialCC: nonamedotc
Git done (by process-git-requests).