Bug 455137 - Review Request: soundmodem - Soundcard Packet Radio Modem
Review Request: soundmodem - Soundcard Packet Radio Modem
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-07-12 12:11 EDT by Lucian Langa
Modified: 2008-12-08 05:51 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-12-08 05:51:34 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
kevin: fedora‑cvs+

Attachments (Terms of Use)
remove spurious printf's (593 bytes, patch)
2008-12-06 12:28 EST, Alan Crosswell
no flags Details | Diff
SPEC to apply spurious printf patch (2.11 KB, application/octet-stream)
2008-12-06 12:31 EST, Alan Crosswell
no flags Details
applies soundmodem-spurious-printf.patch (2.81 KB, application/octet-stream)
2008-12-06 12:39 EST, Alan Crosswell
no flags Details

  None (edit)
Description Lucian Langa 2008-07-12 12:11:29 EDT
Spec URL: http://lucilanga.fedorapeople.org/soundmodem.spec
SRPM URL: http://lucilanga.fedorapeople.org/soundmodem-0.10-1.fc9.src.rpm
Description: This package contains the driver and the diagnostic utility for
userspace SoundModem. It allows you to use soundcards supported
by OSS/Free as Amateur Packet Radio modems.
Comment 1 Bill Nottingham 2008-07-17 10:51:33 EDT
Our drivers aren't OSS/Free (they're alsa), so that description could probably
use some rewording. Maybe just 's|supported by OSS/Free||'
Comment 2 Lucian Langa 2008-07-17 11:08:01 EDT
I've updated the description and bumped version

new files:

Comment 3 Jason Tibbitts 2008-11-20 12:57:36 EST
This failed to build for me on x86_64 with current rawhide:

+ ./configure --build=x86_64-unknown-linux-gnu --host=x86_64-unknown-linux-gnu --target=x86_64-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com --mandir=/usr/share/man --infodir=/usr/share/info
checking build system type...
Invalid configuration `x86_64-unknown-linux-gnu': machine `x86_64-unknown' not recognized
configure: error: /bin/sh ./config.sub x86_64-unknown-linux-gnu failed

I do not know what that means.  Maybe the configure script was simply generated by a really old autotools version?
Comment 4 Lucian Langa 2008-11-21 09:22:08 EST
(In reply to comment #3)
> I do not know what that means.  Maybe the configure script was simply generated
> by a really old autotools version?
I've used autotools to update.

new ver:
Comment 5 Jason Tibbitts 2008-12-02 20:53:45 EST
Builds fine and rpmlint is silent.

The documentation files are duplicated between the main and -devel package.

Unfortunately, modem.h and simd.h are far too generic to place in /usr/include.

* source files match upstream.  sha256sum:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   soundmodem = 0.10-3.fc11
   soundmodem(x86-64) = 0.10-3.fc11

   soundmodem-devel = 0.10-3.fc11
   soundmodem-devel(x86-64) = 0.10-3.fc11
   soundmodem = 0.10-3.fc11

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X generically named files
* scriptlets present OK (service management).
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
Comment 6 Lucian Langa 2008-12-03 05:59:09 EST
(In reply to comment #5)
> The documentation files are duplicated between the main and -devel package.
Updated, there's no doc files for devel package.

> Unfortunately, modem.h and simd.h are far too generic to place in /usr/include.
Moved'em to /usr/include/soundmodem.

Comment 7 Alan Crosswell 2008-12-06 12:28:16 EST
Created attachment 326008 [details]
remove spurious printf's

I've removed two spurious printfs that were resulting in the syslog buffers getting filled up when soundmodem runs as daemon.  I've been running soundmodem in two production aprsdigi's for several years with this patch.  Without it, soundmodem would randomly exit.
Comment 8 Alan Crosswell 2008-12-06 12:31:21 EST
Created attachment 326009 [details]
SPEC to apply spurious printf patch

This is the SPEC to apply the spurious printf's patch.
Comment 9 Alan Crosswell 2008-12-06 12:39:07 EST
Created attachment 326010 [details]
applies soundmodem-spurious-printf.patch

Sorry, I patched against what is in the fedora SRPM.  Here's the update against the 10.4 spec.
Comment 10 Jason Tibbitts 2008-12-06 12:48:49 EST
The issues I had with this review have been fixed.  It would be nice to address
the above mentioned code quality issue, which I have no way to test, but I'm
going to leave that up to Lucian.  Alan, if your issue is not addressed when
this package is imported, please consider filing a bug against it. 
Unfortunately you can't do that now because the review isn't finished and so
the bugzilla component doesn't exist yet.  It should be available soon after
the CVS request has been processed.

Anyway, I'm going to approve this and leave it to Lucian to decide what to do
with the above patch.

Comment 11 Lucian Langa 2008-12-06 16:20:46 EST
Thank you, Jason.
Alan, thank you for the patch, I'm going to handle this after I check this in.

New Package CVS Request
Package Name: soundmodem
Short Description: Soundcard Packet Radio Modem
Owners: lucilanga
Branches: F-9 F-10 EL-5
Comment 12 Kevin Fenzi 2008-12-06 22:30:33 EST
cvs done.
Comment 13 Fedora Update System 2008-12-08 05:48:23 EST
soundmodem-0.10-5.fc9 has been submitted as an update for Fedora 9.
Comment 14 Fedora Update System 2008-12-08 05:49:35 EST
soundmodem-0.10-5.fc10 has been submitted as an update for Fedora 10.

Note You need to log in before you can comment on or make changes to this bug.