Description: Laconica is an open source microblogging tool written in PHP. All data is stored in a MySQL database. Laconica was created as a direct response of a need to create an open source, distributed alternative to Twitter. Laconica implements the OpenMicroBlogging standard. SRPM: http://rakesh.fedorapeople.org/srpm/php-laconica-0.4.1-1.fc8.src.rpm SPEC: http://rakesh.fedorapeople.org/spec/php-laconica.spec This is my 8th package and I am looking for sponsor Additional info: This review depends upon three bugs: https://bugzilla.redhat.com/show_bug.cgi?id=227190 https://bugzilla.redhat.com/show_bug.cgi?id=455039 https://bugzilla.redhat.com/show_bug.cgi?id=454395 laconica development is going in leaps and the current used is 0.4.3. But when this bug was filed it was still to be tested and it also used xmpphp svn checkout which is not released yet.
As soon as 0.4.3 is tested and php-xmpphp next stable released I will update. May be few more days.
This need an update. I will wait till these two dependent package reviews are done: https://bugzilla.redhat.com/show_bug.cgi?id=455039 php-oauth https://bugzilla.redhat.com/show_bug.cgi?id=454395 php-xmpphp
Will update shortly. This needs some more work. Both php-oauth and php-xmpphp are APPROVED
I'll revew it
Thanks, Please hold on for some time. Thanks -- it needs an update badly -- I will post update ASAP.
Please continue ... http://koji.fedoraproject.org/koji/taskinfo?taskID=798538 Build successfully. http://rakesh.fedorapeople.org/spec/php-laconica.spec http://rakesh.fedorapeople.org/srpm/php-laconica-0.5.0-1.fc9.src.rpm
Still here. Sorry for the delay - I was at my vacation.
Remarks: * use cp -a for copying (to preserve timestamps) * no need to mkdir -p $RPM_BUILD_ROOT * I didn't understand a trick with %docdir. Why not to simply add the next line in %files section? %doc COPYING doc/* Other things looks sane.
yes, I agree on all. Will update ... Thanks
http://koji.fedoraproject.org/koji/taskinfo?taskID=849443 http://rakesh.fedorapeople.org/spec/php-laconica.spec http://rakesh.fedorapeople.org/srpm/php-laconica-0.5.0-2.fc9.src.rpm Thanks Rakesh Pandit
REVIEW: + rpmlint is silent on every package. + The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source [petro@Sulaco SOURCES]$ md5sum laconica-0.5.0.tar.gz* c427521f2df6ce6c7962e8da19d57850 laconica-0.5.0.tar.gz c427521f2df6ce6c7962e8da19d57850 laconica-0.5.0.tar.gz.orig [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one supported architecture (ppc). + No additional build dependencies. + No shared library files. + The package isn't designed to be relocatable. + The package owns all directories that it creates. + The package does not contain any duplicate files in the %files listing. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. + The package consistently uses macros, as described in the macros section of Packaging Guidelines . + The package contains code, or permissable content. + No large documentation files. + All, the package includes as %doc, does not affect the runtime of the application. + No header files. + No static libraries. + No pkgconfig(.pc) files. + The package does NOT contain any .la libtool archives. + Not a GUI app. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. + All filenames in rpm package are valid UTF-8. Few remarks: * Please, remove the rest of %{docdir} stuff (see attached patch) * Consider adding additional "Provides: laconica" for those who wants to install it by simply typing "sudo yum install laconica". That's just my personal wish and not a blocker. And this package is APPROVED.
Created attachment 318001 [details] removes the rest of %{docdir} mentions
Thanks I will apply all your changes.
Hi Rakesh, Can you put the cvs request in the correct format please? It helps cvs admins.
Aah!! :( I forgot. Thanks New Package CVS Request ======================= Package Name: php-laconica Short Description: PHP tool for microblogging Owners: rakesh Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
cvs done.
Ping!
I will import it now. Thanks for reminder.
php-laconica-0.5.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/php-laconica-0.5.0-3.fc9
php-laconica-0.5.0-3.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/php-laconica-0.5.0-3.fc8
php-laconica-0.5.0-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
php-laconica-0.5.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.