Spec URL: http://lucilanga.fedorapeople.org/TrustedQSL.spec SRPM URL: http://lucilanga.fedorapeople.org/TrustedQSL-1.11-1.fc9.src.rpm Description: The TrustedQSL applications are used for generating digitally signed QSO records (records of Amateur Radio contacts). This package contains the GUI applications tqslcert and tqsl.
Build error: + mkdir -p /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/applications + mkdir -p /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/pixmaps + cp icons/key48.png /var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/pixmaps/TrustedQSL.png + sed -i -e s/.png//g tqsl.desktop + sed -i -e s/.png//g tqslcert.desktop + desktop-file-install --vendor=fedora --dir=/var/tmp/TrustedQSL-1.11-1.fc9-root-limb/usr/share/applications /home/limb/rpmbuild/BUILD/tqsl.desktop Error on file "/home/limb/rpmbuild/BUILD/tqsl.desktop": No such file or directory error: Bad exit status from /var/tmp/rpm-tmp.32062 (%install) If you drop the %{builddir} it works. Also, you need to BuildRequire desktop-file-utils and expat-devel. rpmlint is clean on everything. Since upstream uses lowercase some places in their naming and uppercase in others, from what I see, it might be better to make this package's name all lowercase. Your call. Comment on status of your patches WRT upstream. If submitted upstream, indicate this in the spec. If not, do so, and indicate in the spec. Add ChangeLog, INSTALL and the help/ dir to %doc. Otherwise, full review looks good. I'm doing another mock build, I'll post back with any further BR issues.
No more BR issues.
(In reply to comment #1) > If you drop the %{builddir} it works. fixed > Also, you need to BuildRequire desktop-file-utils and expat-devel. fixed > Since upstream uses lowercase some places in their naming and uppercase in > others, from what I see, it might be better to make this package's name all > lowercase. Your call. lowered the name > Comment on status of your patches WRT upstream. If submitted upstream, > indicate this in the spec. If not, do so, and indicate in the spec. fixed > Add ChangeLog, INSTALL and the help/ dir to %doc. Added ChangeLog and help/*, INSTALL is only required for people that want to compile this from source. also add detection for zlib, expat on x86_64 arch (koji failed to build those) .. and bumped version to: http://lucilanga.fedorapeople.org/trustedqsl.spec http://lucilanga.fedorapeople.org/trustedqsl-1.11-2.fc10.src.rpm
Drop an 'o' from losing, line 11. Otherwise, looks great. APPROVED. Thanks!
New Package CVS Request ======================= Package Name: trustedqsl Short Description: TrustedQSL ham-radio applications Owners: lucilanga Branches: F-8 F-9 EL-5 InitialCC:
cvs done.
trustedqsl-1.11-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/trustedqsl-1.11-2.fc8
trustedqsl-1.11-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/trustedqsl-1.11-2.fc9
trustedqsl-1.11-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
trustedqsl-1.11-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.