SRPM URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DB2-0.05-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DB2.spec Description: This module understands the formats used by DB2 for its DATE, TIME, and TIMESTAMP data types. It can be used to parse these formats in order to create DateTime objects, and it can take a DateTime object and produce a string representing it in the DB2 format.
http://koji.fedoraproject.org/koji/taskinfo?taskID=721698
Review: + package builds in mock (rawhide i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=721698 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a60a9535dcfab4458740c4805adcdd2b DateTime-Format-DB2-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=25, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.51 cusr 0.03 csys = 0.56 CPU) + Package perl-DateTime-Format-DB2-0.05-1.fc10 => Provides: perl(DateTime::Format::DB2) = 0.05 Requires: perl(DateTime) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-DateTime-Format-DB2 Short Description: Parse and format DB2 dates and times Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done.
Imported and building. Thanks for the review! :)