Bug 455684 - Review Request: perl-DateTime-Format-DB2 - Parse and format DB2 dates and times
Review Request: perl-DateTime-Format-DB2 - Parse and format DB2 dates and times
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/DateTime-...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-16 20:17 EDT by Chris Weyl
Modified: 2008-07-22 19:44 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-22 19:44:35 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2008-07-16 20:17:22 EDT
SRPM URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DB2-0.05-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DB2.spec

Description:
This module understands the formats used by DB2 for its DATE, TIME, and
TIMESTAMP data types. It can be used to parse these formats in order to
create DateTime objects, and it can take a DateTime object and produce a
string representing it in the DB2 format.
Comment 2 Parag AN(पराग) 2008-07-22 01:12:16 EDT
Review:
+ package builds in mock (rawhide i386).
koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=721698
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a60a9535dcfab4458740c4805adcdd2b  DateTime-Format-DB2-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=25,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.51 cusr  0.03
csys =  0.56 CPU)
+ Package perl-DateTime-Format-DB2-0.05-1.fc10 =>
Provides: perl(DateTime::Format::DB2) = 0.05
Requires: perl(DateTime) perl(strict) perl(vars)

APPROVED.

Comment 3 Chris Weyl 2008-07-22 01:22:37 EDT
New Package CVS Request
=======================
Package Name: perl-DateTime-Format-DB2
Short Description: Parse and format DB2 dates and times
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig
Comment 4 Kevin Fenzi 2008-07-22 12:00:15 EDT
cvs done.
Comment 5 Chris Weyl 2008-07-22 19:44:35 EDT
Imported and building.  Thanks for the review! :)

Note You need to log in before you can comment on or make changes to this bug.