Red Hat Bugzilla – Bug 455788
Review Request: perl-DateTime-Format-DBI - Find a parser class for a database connection
Last modified: 2008-07-24 19:03:33 EDT
SRPM URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DBI-0.031-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DBI.spec Description: This module finds a DateTime::Format::* class that is suitable for the use with a given DBI connection (and DBD::* driver). Note that this is most useful if you actually have the DateTime::Format::* class for your particular database(s) installed! See, e.g., perl-DateTime-MySQL, perl-DateTime-Oracle, perl-DateTime-DB2, etc.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=722957
Review: + package builds in mock (rawhide i386). koji build=>http://koji.fedoraproject.org/koji/taskinfo?taskID=722957 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 97efe8dfe3a6e68cfb9489c451cd16dd DateTime-Format-DBI-0.031.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.04 cusr 0.00 csys = 0.05 CPU) + Package perl-DateTime-Format-DBI-0.031-1.fc10 => Provides: perl(DateTime::Format::DBI) = 0.0 Requires: perl(Carp) perl(DBI) >= 1.21 perl(strict) perl(vars) I am not sure why provides is giving 0.0 whereas I can see code $VERSION = '0.031'; $VERSION = $VERSION + 0.0; shouldn't it be summed to 0.031 ?
This appears to be a bug in rpm's perl.prov script. Though it's careful to not clobber the discovered version on finding multiple chunks of the same package, it'll keep on overwriting it with each new assignment. I've opened bug 456357 (another cool integer <grin />) to address this, and overridden the auto-provided value for this package in the meantime. SRPM URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DBI-0.031-2.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-DateTime-Format-DBI.spec
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=735907 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 97efe8dfe3a6e68cfb9489c451cd16dd DateTime-Format-DBI-0.031.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.00 usr 0.00 sys + 0.04 cusr 0.00 csys = 0.04 CPU) + Package perl-DateTime-Format-DBI-0.031-2.fc10 => Provides: perl(DateTime::Format::DBI) = 0.031 Requires: perl(Carp) perl(DBI) >= 1.21 perl(strict) perl(vars) APPROVED
New Package CVS Request ======================= Package Name: perl-DateTime-Format-DBI Short Description: Find a parser class for a database connection Owners: cweyl Branches: F-8, F-9, devel InitialCC: perl-sig
cvs done.
Imported and building. Thanks for the review! :-)