Bug 455913 - memberOf plug-in shouldn't use a Slapi_Mod on the stack
memberOf plug-in shouldn't use a Slapi_Mod on the stack
Product: 389
Classification: Community
Component: Server - Plugins (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: Rich Megginson
Chandrasekar Kannan
Depends On:
Blocks: 249650 FDS112
  Show dependency treegraph
Reported: 2008-07-18 13:57 EDT by Nathan Kinder
Modified: 2015-01-04 18:33 EST (History)
3 users (show)

See Also:
Fixed In Version: 8.1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-04-29 19:05:05 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
CVS Diffs (2.54 KB, patch)
2008-07-18 13:57 EDT, Nathan Kinder
no flags Details | Diff

  None (edit)
Description Nathan Kinder 2008-07-18 13:57:31 EDT
There's a spot in the memberOf plug-in where we use a Slapi_Mod on the stack. 
While this works fine, it requires knowledge of how much space a Slapi_Mod takes
up, which is not exported via the public interface.  We should only be using the
public interfaces if possible.

The fix is to allocate a Slapi_Mod on the heap instead.
Comment 1 Nathan Kinder 2008-07-18 13:57:31 EDT
Created attachment 312161 [details]
CVS Diffs
Comment 2 Nathan Kinder 2008-07-18 14:12:03 EDT
Checked into ldapserver (HEAD).  Thanks to Noriko for her review!

Checking in plugins/memberof/memberof.c;
/cvs/dirsec/ldapserver/ldap/servers/plugins/memberof/memberof.c,v  <--  memberof.c
new revision: 1.13; previous revision: 1.12
Comment 3 Jenny Galipeau 2009-04-09 14:45:29 EDT
I'm not sure that QE can verify this bug?
Comment 4 Nathan Kinder 2009-04-09 17:34:52 EDT
This fix is a code optimization, and is not verifiable by QE.  Marking as VERIFIED.
Comment 5 Chandrasekar Kannan 2009-04-29 19:05:05 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.