Description : DeviceKit-disks provides a daemon, D-Bus API and command line tools for managing disks and storage devices. http://people.freedesktop.org/~david/gdu-dkd-review/DeviceKit-disks.spec http://people.freedesktop.org/~david/gdu-dkd-review/DeviceKit-disks-002-0.git20080720.fc10.src.rpm
See also bug 456032 and bug 456034.
Seems you are missing a BR against device-mapper-devel
and intltool
rpmlint says: [mclasen@golem ~]$ rpmlint DeviceKit-disks-* DeviceKit-disks.i386: E: executable-sourced-script /etc/profile.d/devkit-disks-bash-completion.sh 0755 DeviceKit-disks.i386: W: non-conffile-in-etc /etc/udev/rules.d/95-devkit-disks.rules DeviceKit-disks.i386: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.DeviceKit.Disks.conf 3 packages and 0 specfiles checked; 1 errors, 2 warnings.
The to conffile warning can probably be ignored, if it is common practise to treat udev rules not as conffiles. The executable-sourced-script warning should probably be fixed
package name: ok spec file name: ok packaging guidelines: - the source tag points to a nonexisting file. Should just make it a filename and add a comment explaining that this is a git snapshot (see https://fedoraproject.org/wiki/Packaging/SourceURL) - the handling of %doc content should be straightened out license: ok license field: ok license file: ok spec language: ok spec legibility: ok upstream sources: ok buildable: yes ExcludeArch: n/a BuildRequires: see above, missing device-mapper-devel and intltool locale handling: n/a ldconfig: n/a relocatable: n/a directory ownership: - must not own /usr/share/PolicyKit/policy duplicate files: ok permissions: ok %clean: ok macro use: ok content: permissible large docs: n/a %doc content: ok header files: n/a static libraries: n/a pc files: n/a shared libraries: n/a devel deps: ok libtool archives: ok gui apps: n/a directory ownership: - see above about /usr/share/PolicyKit/policy %install: ok utf8 filenames: ok
Thanks for the review; uploaded new SPEC and SRPM at the same location. Does it look OK?
Ah, one I overlooked: %dir %{_datadir}/dbus-1/interfaces You shouldn't own that directory either. Instead, fix dbus to own it.
(In reply to comment #8) > Ah, one I overlooked: > > %dir %{_datadir}/dbus-1/interfaces > > You shouldn't own that directory either. Fine. Fixed. Uploaded the new SPEC and SRPM. Thanks.
Looking good now.
New Package CVS Request ======================= Package Name: DeviceKit-disks Short Description: Disk Management Service Owners: davidz Branches: InitialCC: Cvsextras Commits: yes
cvs done.