This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 456205 - Review Request: disktype - Disk and disk image format analyzer
Review Request: disktype - Disk and disk image format analyzer
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-22 03:48 EDT by Rahul Sundaram
Modified: 2013-03-13 01:43 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-23 01:59:49 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Rahul Sundaram 2008-07-22 03:48:25 EDT
Spec URL: http://sundaram.fedorapeople.org/packages/disktype.spec
SRPM URL: http://sundaram.fedorapeople.org/packages/disktype-9-1.fc9.src.rpm

Description: 

The purpose of disktype is to detect the content format of a disk or
disk image. It knows about common file systems, partition tables, and
boot codes.
Comment 1 Parag AN(पराग) 2008-07-23 00:52:43 EDT
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733104
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
25a673f162b9c01cd565109202559489  disktype-9.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
- BuildRequires are NOT proper. You should remove BR:glibc-kernheaders
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ package installed successfully.

SHOULD:
   should remove BR:glibc-kernheaders
APPROVED.
Comment 2 Rahul Sundaram 2008-07-23 01:59:49 EDT
We just realized, this package already exists in the repo. My bad. Sorry for
wasting your time, Parag. 

Note You need to log in before you can comment on or make changes to this bug.