Red Hat Bugzilla – Bug 456205
Review Request: disktype - Disk and disk image format analyzer
Last modified: 2013-03-13 01:43:30 EDT
Spec URL: http://sundaram.fedorapeople.org/packages/disktype.spec SRPM URL: http://sundaram.fedorapeople.org/packages/disktype-9-1.fc9.src.rpm Description: The purpose of disktype is to detect the content format of a disk or disk image. It knows about common file systems, partition tables, and boot codes.
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733104 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 25a673f162b9c01cd565109202559489 disktype-9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. - BuildRequires are NOT proper. You should remove BR:glibc-kernheaders + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + package installed successfully. SHOULD: should remove BR:glibc-kernheaders APPROVED.
We just realized, this package already exists in the repo. My bad. Sorry for wasting your time, Parag.