Spec URL: http://kushal.fedorapeople.org/chm2pdf.spec SRPM URL: http://kushal.fedorapeople.org/chm2pdf-0.9.1-1.fc9.src.rpm Description: A simple Python script that converts CHM files into PDF files.
Fixed the Group Spec URL: http://kushal.fedorapeople.org/chm2pdf.spec SRPM URL: http://kushal.fedorapeople.org/chm2pdf-0.9.1-2.fc9.src.rpm
Package has a small license field issue. Rest package is okay. Required: [x] rpmlint output: clean [x] package and spec naming [x] packaging guideline [x] license file included [!] license field should be GPLv2+ [x] spec file -- is legible and written in American English [x] md5sum Upstream: 2d5518e3284cca496270566c2554b713 Package Source: 2d5518e3284cca496270566c2554b713 [x] package builds on koji [x] package working on i686 [x] BuildRequires tag [NA] locales [NA] static libraries, shared libraries, header files [x] owns directory it creates [x] no duplicates files [x] file permissions [x] %clean and %install section have rm -rf $RPM_BUILD_ROOT [x] macros used consistently [x] package has permissible content [x] program runs independent of files in %doc [NA] GUI [x] All file encoding is utf-8 [x] no unnecessary bite compilation [x] egg-info file included [x] Optional: [x] LICENSE file included [x] description and summary not available in other languages [x] package builds in koji [x] package works as expected [NA] no sciriptlets [NA] no subpackages [x] no dependencies outside paths in FH Guidelines Optional Suggestions(you may consider not using them): a. you can remove python_sitearch definition as it is not being used Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated
Spec URL: http://kushal.fedorapeople.org/chm2pdf.spec SRPM URL: http://kushal.fedorapeople.org/chm2pdf-0.9.1-3.fc9.src.rpm Hopefully everything is fixed now :)
Yes, very much -- everything is fixed. You may like to put in "Fixed License field" in changelog in place of "Fixed as asked in the review" APPROVED
New Package CVS Request ======================= Package Name: chm2pdf Short Description: A tool to convert CHM files to PDF files Owners: kushal Branches: F-9 EL5 InitialCC: kushal Cvsextras Commits: yes
cvs done.