Bug 456570 - loader can't find disc after media check
Summary: loader can't find disc after media check
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F10Alpha, F10AlphaBlocker
TreeView+ depends on / blocked
 
Reported: 2008-07-24 18:31 UTC by Will Woods
Modified: 2008-07-25 20:32 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-07-25 20:32:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Will Woods 2008-07-24 18:31:38 UTC
After running a mediacheck with anaconda-11.4.1.6, loader is unable to find the
disc under any circumstances.

There's two bugs at work here. First, the kernel doesn't tell us properly when
the drive is checking media. This causes the mount command to fail with 'No
medium found'. There's another bug (somewhere) about this, but the workaround is
to wait a few seconds after inserting the disc before hitting "OK".

*This* bug is that, even if you wait ~20 seconds after inserting the disc,
loader can't find it and ejects it again. 

The logs show no errors returned from the mount command, and the kernel emits
iso9660-specific filesystem probing messages. So I believe it *is* being mounted
properly.

I think the problem is that loader2/cdinstall.c has the logic inverted on this
access() call:

                if (!access(stage2loc, R_OK)) {
                    free(stage2loc);
                    umount(location);
                    ejectCdrom(dev);
                    wrongCDMessage();
                    continue;
                }

access(2) says "On success (all requested permissions granted), zero is
returned." So the test should probably be: 

                if (access(stage2loc, R_OK) != 0) {

Comment 1 Will Woods 2008-07-24 18:32:26 UTC
Sorry, that's anaconda-11.4.1.16, not .6

Comment 2 Chris Lumens 2008-07-24 18:33:15 UTC
I just pushed a fix for this, so it should be fixed in anaconda-11.4.1.19-1.

Comment 3 Will Woods 2008-07-25 20:32:04 UTC
Confirmed fixed. Thanks!


Note You need to log in before you can comment on or make changes to this bug.