Spec URL: http://0pointer.de/public/libatasmart.spec SRPM URL: http://0pointer.de/public/libatasmart-0.1-1.fc10.src.rpm Description: A small and lightweight parser library for ATA S.M.A.R.T. hard disk health monitoring. Future versions of DeviceKit-disks will depend on this.
[-] source files match upstream: it doesn't fbffdc4551dd63368babf6fdd659a4bef8e0e647 vs 23116bb3a88fb9ccfbe229ac5a209beb8c80535f please package the upstream tarball (When doing changes upstream please bump the release) [+] package meets naming and versioning guidelines. [+] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [-] license field matches the actual license: The spec says "License: LGPLv2" while the source files say "or (at your option) any later version." Please change to LGPLv2+ [+] license is open source-compatible. [+] license text included in package. [?] latest version is being packaged: The version number is the lastest but the checksums do not match (see first comment) [+] BuildRequires are proper. [+] compiler flags are appropriate. [+] %clean is present. [+] package builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=740525 [+] package installs properly. [+] debuginfo package looks complete. [+] rpmlint output: Shows one waring "libatasmart-devel.x86_64: W: no-documentation" can be safly ignored. [+] ldconfig is used in %post and %postun [+] no duplicates in %files. [+] file permissions are appropriate. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. ------ Package looks good to me please fix the two issues noted and I will approve it. * package correct upstream tarball * fix license tag
One more thing pass %{?_smp_mflags} to the make command.
(In reply to comment #1) > [-] source files match upstream: > it doesn't fbffdc4551dd63368babf6fdd659a4bef8e0e647 vs > 23116bb3a88fb9ccfbe229ac5a209beb8c80535f Fixed. Since I am both upstream and the packager I got a bit confused I guess. > [-] license field matches the actual license: > The spec says "License: LGPLv2" while the source files say "or (at your > option) any later version." > Please change to LGPLv2+ Fixed. (In reply to comment #2) > One more thing pass %{?_smp_mflags} to the make command. Fixed. I uploaded the spec file and the srpm to the same location. I didn't bump the rpm revision.
(In reply to comment #3) > (In reply to comment #1) > > [-] source files match upstream: > > it doesn't fbffdc4551dd63368babf6fdd659a4bef8e0e647 vs > > 23116bb3a88fb9ccfbe229ac5a209beb8c80535f > > Fixed. Since I am both upstream and the packager I got a bit confused I guess. OK both are the same now (fbffdc4551dd63368babf6fdd659a4bef8e0e647). I know that you are upstream, hence the comment about bumping the version when generating new tarballs ;) > > [-] license field matches the actual license: > > The spec says "License: LGPLv2" while the source files say "or (at your > > option) any later version." > > Please change to LGPLv2+ > > Fixed. OK > (In reply to comment #2) > > One more thing pass %{?_smp_mflags} to the make command. > > Fixed. OK > I uploaded the spec file and the srpm to the same location. I didn't bump the > rpm revision. You should (even during the review process). As for the package now its fine. => APPROVED
New Package CVS Request ======================= Package Name: libatasmart Short Description: ATA S.M.A.R.T. Disk Health Monitoring Library Owners: lennart Branches: InitialCC: Cvsextras Commits: yes
cvs done.