Bug 457018 - pppoe: Unshare skb before anything else [rhel-5.3]
Summary: pppoe: Unshare skb before anything else [rhel-5.3]
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.3
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Jiri Pirko
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks: 457019 457020
TreeView+ depends on / blocked
 
Reported: 2008-07-29 08:38 UTC by Eugene Teo (Security Response)
Modified: 2015-05-05 01:15 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 20:24:28 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:0225 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.3 kernel security and bug fix update 2009-01-20 16:06:24 UTC

Description Eugene Teo (Security Response) 2008-07-29 08:38:35 UTC 
Description of problem:
We need to unshare the skb first as otherwise pskb_may_pull may write to a
shared skb which could be bad.
Comment 1 Eugene Teo (Security Response) 2008-07-29 08:39:18 UTC 
Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=bc6cffd177f9266af38dba96a2cea06c1e7ff932
Comment 2 Jiri Pirko 2008-08-13 12:31:13 UTC 
I also found that this should be changed in pppoe_rcv() function. Please eteo create bz for it.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=31bac44468257986484703cc09da8a9dcae88a36
Comment 3 Eugene Teo (Security Response) 2008-08-14 06:44:02 UTC 
(In reply to comment #2)
> I also found that this should be changed in pppoe_rcv() function. Please eteo
> create bz for it.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=31bac44468257986484703cc09da8a9dcae88a36

Thanks Jiri. I have created the bugs for this:
rhel-4.8 [#459063:NEW], and rhel-5.3 [#459062:NEW].
Comment 4 Don Zickus 2008-09-03 03:40:57 UTC 
in kernel-2.6.18-107.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5
Comment 8 errata-xmlrpc 2009-01-20 20:24:28 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html
Note You need to log in before you can comment on or make changes to this bug.