Bug 457025 - ide-cd: fix oops when using growisofs [rhel-5.3]
Summary: ide-cd: fix oops when using growisofs [rhel-5.3]
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.3
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Mauro Carvalho Chehab
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks: 457027 457028 457029
TreeView+ depends on / blocked
 
Reported: 2008-07-29 10:07 UTC by Eugene Teo (Security Response)
Modified: 2009-01-20 20:25 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 20:25:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Backport of mainstream patches (1.23 KB, patch)
2008-08-19 00:40 UTC, Mauro Carvalho Chehab
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:0225 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.3 kernel security and bug fix update 2009-01-20 16:06:24 UTC

Description Eugene Teo (Security Response) 2008-07-29 10:07:00 UTC
Description of problem:
cdrom_read_capacity() will blindly return the capacity from the device without
sanity-checking it.  This later causes code in fs/buffer.c to oops.

Fix this by checking that the device is telling us sensible things.

Comment 2 Eugene Teo (Security Response) 2008-07-29 10:10:29 UTC
With reference to http://lkml.org/lkml/2008/6/22/90, problem was triggered by
running "genisoimage -C 16,737776 -M /dev/fd/3 -R -J foobar | builtin_dd
of=/dev/dvd obs=32k seek=46111" on a ppc64 machine.

Comment 3 Eugene Teo (Security Response) 2008-08-18 01:36:56 UTC
There's a follow-up patch that fixes a bug in commit
e8e7b9eb11c34ee18bde8b7011af41938d1ad667. Please include commit 938bb03d188a1e688fb0bcae49788f540193e80a in your backported patch. Thanks.

Comment 4 Mauro Carvalho Chehab 2008-08-19 00:40:24 UTC
Created attachment 314506 [details]
Backport of mainstream patches

The attached patch is the backport of the upstream git patches.

On all tests I did here with RHEL5 with and without the patch, I couldn't
reproduce the bug on i386. I suspect that it occurs only on some other
architecture (the original report were on ppc64), or when the first DVD record
has an unusual block size.

The patch were posted today.

Comment 5 Don Zickus 2008-09-10 20:14:22 UTC
in kernel-2.6.18-110.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 9 errata-xmlrpc 2009-01-20 20:25:03 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html


Note You need to log in before you can comment on or make changes to this bug.