Spec URL: http://katzj.fedorapeople.org/review/sugar-terminal/sugar-terminal.spec SRPM URL: http://katzj.fedorapeople.org/review/sugar-terminal/sugar-terminal-13-1.fc10.src.rpm Description: Terminal activity for sugar
- rpmlint is very noisy: sugar-terminal.src: W: non-standard-group Sugar/Activities * Sugar/Activities should probably be added to the standard groups list. * Filed https://bugzilla.redhat.com/show_bug.cgi?id=458460 to get this done. sugar-terminal.noarch: E: non-executable-script /usr/share/sugar/activities/Terminal.activity/setup.py 0644 * Probably just patch out the shebang line or make it non-executable since this shouldn't be needed at runtime. sugar-terminal.noarch: W: file-not-in-%lang /usr/share/sugar/activities/Terminal.activity/locale/af/LC_MESSAGES/org.laptop.Terminal.mo (...lots more...) * Ongoing discussion as to what to do about this on fedora-olpc-list. No point in blocking the review, we'll just fix it when the proper course of action is decided. - Package naming is fine - License is fine - Source matches upstream (git checkout of a tag) - Spec file is fine - File list is fine (except for translations) APPROVED (Once you fix the rpmlint error)
The setup.py thing needs to be fixed in the sugar BundleBuilder so that we avoid proliferating noise into every spec file. Started a discussion about that also. Since if we're going to be packaging a number of activities, we should be doing it in a way that doesn't involve a lot of cut and paste boiler-plate "work around the system" types of things. Will hold off on cvs request (and filing the other review tickets I've got) until we get a little bit of somewhere on the two issues
Okay, with the fixes in sugar-toolkit-0.82.5-2, things work nicely now New Package CVS Request ======================= Package Name: sugar-terminal Short Description: Terminal activity for sugar Owners: katzj Branches: devel
btw, I don't mind to be listed as co-maintainer (rnorwood) for any of these activity packages if you like.
cvs done.
And building
Package Change Request ====================== Package Name: sugar-terminal New Branches: EL-6 Owners: pbrobinson sdz
Have you checked with tuxbrewr to see if he would like to maintain this in EPEL?