Spec URL: http://overholt.fedorapeople.org/rome.spec
SRPM URL: http://overholt.fedorapeople.org/rome-0.9-1.fc9.src.rpm
Description: ROME is an set of open source Java tools for parsing, generating and
publishing RSS and Atom feeds.
Note: this package was not based on the JPackage ROME package as it uses maven 1. I wrote this from scratch based on the Fedora Java packaging guidelines.
Jesse: I know you use Mylyn and this blocks the new version of Mylyn so ...
care to review it? Pretty please? :)
Taking on this review.
The instructions for getting the source need work. I wind up with a file named "rome-0.9-src.tar.gz\?rev\=1.1"
Naming looks right
javadoc subpackage as expected
buildrequires and requires seem correct
successfully avoids building against the pre-shipped jar file.
Everything looks good here. rpmlint only complains about a lack of documentation, and a non-standard group which is ignorable in my book. I'm passing this review.
Thanks, Jesse. I'll add an mv after the wget in the source-getting instructions.
New Package CVS Request
Package Name: rome
Short Description: ROME is an set of open source Java tools for parsing, generating and publishing RSS and Atom feeds.
Cvsextras Commits: yes
Sorry, should have closed this already.