Bug 457547 - Review Request: mediascrapper - A script to scrap media files from different sites
Summary: Review Request: mediascrapper - A script to scrap media files from different ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-01 13:29 UTC by kushaldas@gmail.com
Modified: 2013-03-13 05:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-13 18:15:30 UTC
Type: ---
Embargoed:
sundaram: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description kushaldas@gmail.com 2008-08-01 13:29:40 UTC
Spec URL: http://kushal.fedorapeople.org/mediascrapper.spec
SRPM URL: http://kushal.fedorapeople.org/mediascrapper-0.1-1.fc9.src.rpm
Description: A script to scrap media files from different sites

Comment 1 Parag AN(पराग) 2008-08-04 10:31:40 UTC
will you please tell me how can I test package? any sample movie.txt you would like to provide here?

Comment 2 kushaldas@gmail.com 2008-08-04 11:28:33 UTC
(In reply to comment #1)
> will you please tell me how can I test package? any sample movie.txt you would
> like to provide here?

Put the following line in a movie.txt in the current folder

http://www.apunkabollywood.net/browser/category/view/3949/rock-on-(2008)

Comment 3 Rahul Sundaram 2008-08-05 14:36:12 UTC
Remove the sitearch macro definition and CFLAGS line. Those are not needed for a noarch package. Include a copy of the license under a file called COPYING. The license of the source should match the tag in the spec file. 

You might also want to move your project to fedorahosted.org and make the script more generic.

Comment 4 kushaldas@gmail.com 2008-08-06 16:53:55 UTC
(In reply to comment #3)
> Remove the sitearch macro definition and CFLAGS line. Those are not needed for
> a noarch package. Include a copy of the license under a file called COPYING.
> The license of the source should match the tag in the spec file. 
> 
> You might also want to move your project to fedorahosted.org and make the
> script more generic.

Spec URL: http://kushal.fedorapeople.org/packages/mediascrapper.spec
SRPM URL: http://kushal.fedorapeople.org/packages/mediascrapper-0.1-2.fc9.src.rpm

I will move the project under fedorahosted. The upcoming release will have feature to download photos from flickr

Comment 5 kushaldas@gmail.com 2008-08-06 17:03:28 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Remove the sitearch macro definition and CFLAGS line. Those are not needed for
> > a noarch package. Include a copy of the license under a file called COPYING.
> > The license of the source should match the tag in the spec file. 
> > 
> > You might also want to move your project to fedorahosted.org and make the
> > script more generic.
> 
> Spec URL: http://kushal.fedorapeople.org/packages/mediascrapper.spec
> SRPM URL:
> http://kushal.fedorapeople.org/packages/mediascrapper-0.1-2.fc9.src.rpm
> 
> I will move the project under fedorahosted. The upcoming release will have
> feature to download photos from flickr

Spec URL: http://kushal.fedorapeople.org/packages/mediascrapper.spec
SRPM URL:
http://kushal.fedorapeople.org/packages/mediascrapper-0.1-3.fc9.src.rpm

Comment 6 Rahul Sundaram 2008-08-06 18:00:59 UTC
Koji scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=763547

Remove the note on the specific website.

Approved.

Comment 7 kushaldas@gmail.com 2008-08-08 08:32:27 UTC
New Package CVS Request
=======================
Package Name: mediascrapper
Short Description: A script to scrap media files from different sites 
Owners: kushal
Branches: F-9 EL-5
InitialCC: kushal
Cvsextras Commits: yes

Comment 8 Kevin Fenzi 2008-08-10 01:10:36 UTC
cvs done.

Comment 9 Fedora Update System 2008-08-12 13:59:37 UTC
mediascrapper-0.1-3.fc9 has been submitted as an update for Fedora 9

Comment 10 Fedora Update System 2008-09-10 06:54:39 UTC
mediascrapper-0.1-3.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Christoph Wickert 2009-07-18 13:19:34 UTC
(In reply to comment #3)
> Include a copy of the license under a file called COPYING.
> The license of the source should match the tag in the spec file. 

Although this package is already in the repo for a while, the License tag is wrong. Should be GLPv2+ instead of GPLv2.

Comment 12 Christoph Wickert 2009-07-18 13:21:48 UTC
Kushal, please update the Source0 on your fedorapeople account to really match the one included in the package. TIA.


Note You need to log in before you can comment on or make changes to this bug.