Bug 457873 - flag visibility error causes bug update to fail
Summary: flag visibility error causes bug update to fail
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: User Interface
Version: 3.2
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Noura El hawary
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-05 05:17 UTC by Noura El hawary
Modified: 2025-10-16 23:18 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-08-08 18:50:58 UTC
Embargoed:


Attachments (Terms of Use)
v1 to fix flag visibility error (2.58 KB, patch)
2008-08-05 05:22 UTC, Noura El hawary
no flags Details | Diff

Description Noura El hawary 2008-08-05 05:17:25 UTC
users are able to view flags in bugs that they don't have permission to view "meaning that they are not in the visibility group of the flag", and when they try to make any change to those bugs they get flag access denied error. for example:

user <karsten> is able to see the flag rhel‑2.1? in bug 453578 even though he is not a memver of the rhel_visible group. when he tries to make any change to that bug 453578 like adding a comment or anything else he get this error:
'You are not authorized to access flag rhel-2.1.'

similar behavior happened with other users like rlerch.


A patch to fix this problem is to be attached shortly.

Noura

Comment 1 Noura El hawary 2008-08-05 05:22:27 UTC
Created attachment 313420 [details]
v1 to fix flag visibility error

this is a patch to solve the problem with the flag visibility error, so basically i am just checking the the flag is visible to the user and the template/user interface level to filter the invisible ones out before display. 

patch is applied to bz-web2 if you would like to test.

Noura

Comment 2 Kevin Baker 2008-08-05 15:19:27 UTC
template/en/default/flag/list.html.tmpl

nitpik: looks like the [% END %] statements in this file don't line up.

Comment 3 David Lawrence 2008-08-08 18:50:58 UTC
The fix for this should be live on the production servers for a short while now. Closing this bug.


Note You need to log in before you can comment on or make changes to this bug.