Bug 458135 - Sort control message should not be logged for internal operations
Summary: Sort control message should not be logged for internal operations
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: 389
Classification: Retired
Component: Directory Server
Version: 1.1.1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nathan Kinder
QA Contact: Chandrasekar Kannan
URL:
Whiteboard:
Depends On:
Blocks: 249650 FDS112
TreeView+ depends on / blocked
 
Reported: 2008-08-06 16:28 UTC by Nathan Kinder
Modified: 2015-01-04 23:33 UTC (History)
3 users (show)

Fixed In Version: 8.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-29 23:05:38 UTC


Attachments (Terms of Use)
CVS Diffs (1.61 KB, patch)
2008-08-06 16:28 UTC, Nathan Kinder
no flags Details | Diff

Description Nathan Kinder 2008-08-06 16:28:05 UTC
Created attachment 313597 [details]
CVS Diffs

The backend plug-in currently attempts to log a message whenever it is processing a sort control as part of a search operation.  For an internal operation, this causes an error to be logged since the connection ID is not set for an internal operation, but the access log needs it for the log message.  Here is the error log message:

  [05/Aug/2008:13:12:34 -0700] - Connection is NULL and hence cannot access SLAPI_CONN_ID

When using the DNA plug-in, you will see lots of these messages since it does an internal sorted search.  We should not attempt to log anything related to the sort control in the access log for internal operations.

Comment 1 Nathan Kinder 2008-08-08 15:53:43 UTC
Checked into ldapserver (HEAD).  Thanks to Rich for his review!

Checking in back-ldbm/ldbm_search.c;
/cvs/dirsec/ldapserver/ldap/servers/slapd/back-ldbm/ldbm_search.c,v  <--  ldbm_search.c
new revision: 1.14; previous revision: 1.13
done

Comment 2 Jenny Severance 2009-04-02 15:00:05 UTC
Can I verify this by executing the DNA acceptance tests and verifying the errors log does not contain this message?  I could add regression test to this suite also.

Comment 3 Jenny Severance 2009-04-02 15:10:05 UTC
/s/errors/access/

Comment 4 Nathan Kinder 2009-04-02 15:13:14 UTC
Yes, check(In reply to comment #2)
> Can I verify this by executing the DNA acceptance tests and verifying the
> errors log does not contain this message?  I could add regression test to this
> suite also.  

Yes, you can verify by checking for the following message in the errors log during the DNA test.  It should not appear.

  [05/Aug/2008:13:12:34 -0700] - Connection is NULL and hence cannot access
SLAPI_CONN_ID

Comment 5 Jenny Severance 2009-04-02 15:17:18 UTC
fix verified DS 8.1 RHEL 5 - adding regression test to DNA acceptance test that will parse both replica's access logs for the error message.

Comment 6 Jenny Severance 2009-04-03 13:55:38 UTC
Test case added to acceptance tests is failing on RHEL 4 64bit and 32 bit with 2882 instances of the error in the access log.

Comment 7 Jenny Severance 2009-04-03 15:40:53 UTC
More investigation - RHEL 4 is problem with test - no actual messages in access log.

Comment 8 Chandrasekar Kannan 2009-04-29 23:05:38 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2009-0455.html


Note You need to log in before you can comment on or make changes to this bug.