Spec URL: http://ibus.googlecode.com/files/ibus-pinyin.spec SRPM URL: http://ibus.googlecode.com/files/ibus-pinyin-0.1.0.20080808-1.fc9.src.rpm Description: It's a Chinese PinYin engine for IBus
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=766028 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 21ddfc9307ac154f0360a36f64dd97f2 ibus-pinyin-0.1.0.20080808.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct with unnecessary extra dependencies perl(XML::Parser) gtk2-devel qt-devel + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. Suggestions: 1) Remove extra BR: perl(XML::Parser) pygtk2 gtk2-devel qt-devel 2) Remove unneeded lines from SPEC %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} APPROVED.
New Package CVS Request ======================= Package Name: ibus-pinyin Short Description: The Chinese PinYin input engine for IBus platform Owners: phuang Branches: F-9 InitialCC: phuang Cvsextras Commits: yes
cvs done.
It has been built in koji.
New Package CVS Request ======================= Package Name: ibus-pinyin Short Description: The Chinese PinYin input engine for IBus platform Owners: phuang Branches: EPEL-5 InitialCC: phuang Cvsextras Commits: yes