Bug 458409 - Review Request: ibus-pinyin - PinYin engine for IBus
Summary: Review Request: ibus-pinyin - PinYin engine for IBus
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-08 01:49 UTC by Peng Huang
Modified: 2008-08-13 08:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-08-13 08:34:16 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peng Huang 2008-08-08 01:49:50 UTC
Spec URL: http://ibus.googlecode.com/files/ibus-pinyin.spec
SRPM URL: http://ibus.googlecode.com/files/ibus-pinyin-0.1.0.20080808-1.fc9.src.rpm
Description: It's a Chinese PinYin engine for IBus

Comment 1 Parag AN(पराग) 2008-08-08 08:24:13 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=766028
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
21ddfc9307ac154f0360a36f64dd97f2  ibus-pinyin-0.1.0.20080808.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are correct with unnecessary extra dependencies  perl(XML::Parser) gtk2-devel qt-devel
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

Suggestions:
  1) Remove extra BR: perl(XML::Parser) pygtk2 gtk2-devel qt-devel
  2) Remove unneeded lines from SPEC
    %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
    %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")}

APPROVED.

Comment 2 Peng Huang 2008-08-08 08:34:14 UTC
New Package CVS Request
=======================
Package Name: ibus-pinyin
Short Description: The Chinese PinYin input engine for IBus platform
Owners: phuang
Branches: F-9
InitialCC: phuang
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-08-10 01:31:04 UTC
cvs done.

Comment 4 Peng Huang 2008-08-10 18:13:37 UTC
It has been built in koji.

Comment 5 Peng Huang 2008-08-13 04:53:37 UTC
New Package CVS Request
=======================
Package Name: ibus-pinyin
Short Description: The Chinese PinYin input engine for IBus platform
Owners: phuang
Branches: EPEL-5
InitialCC: phuang
Cvsextras Commits: yes

Comment 6 Kevin Fenzi 2008-08-13 05:08:21 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.