Bug 458446 - Review Request: perl-HTML-FromText - Convert plain text to HTML
Summary: Review Request: perl-HTML-FromText - Convert plain text to HTML
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 458080
Blocks: 458449
TreeView+ depends on / blocked
 
Reported: 2008-08-08 14:05 UTC by Nicolas Chauvet (kwizart)
Modified: 2008-09-15 13:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-09-15 13:55:25 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Nicolas Chauvet (kwizart) 2008-08-08 14:05:11 UTC
Spec URL:
http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText-2.05-1.fc8.kwizart.src.rpm
Description: Convert plain text to HTML

Comment 1 Parag AN(पराग) 2008-08-08 17:14:54 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=766986
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fb8ae4ab0cae0b57101f78b046b3927b  HTML-FromText-2.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave

+ Package

Comment 2 Parag AN(पराग) 2008-08-08 17:20:23 UTC
oops koji build failed. Thought this is base package. Need to review then bug 458080 first.

Comment 3 Parag AN(पराग) 2008-08-13 05:49:01 UTC
did you asked upstream to fix tests that are failing?

rpmlint reported 
perl-HTML-FromText.noarch: E: non-standard-executable-perm /usr/bin/text2html 0555
==> you need to add following line to %build
%{_fixperms} $RPM_BUILD_ROOT/*

Comment 4 Parag AN(पराग) 2008-08-29 07:23:06 UTC
ping?

Comment 5 Parag AN(पराग) 2008-09-04 05:18:25 UTC
ping again Can you fix issues given in comment #3?

Comment 6 Nicolas Chauvet (kwizart) 2008-09-04 13:03:58 UTC
Spec URL:
http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText.spec
SRPM URL:
http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText-2.05-2.fc8.kwizart.src.rpm
Description: Convert plain text to HTML

Changelog
- Add fixperms

Mail sent today to report the problem at make test.

Comment 7 Parag AN(पराग) 2008-09-04 16:03:17 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=806666
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
fb8ae4ab0cae0b57101f78b046b3927b  HTML-FromText-2.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=13,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.21 cusr  0.02 csys =  0.26 CPU)

+ Package perl-HTML-FromText-2.05-2.fc10 =>
Provides: perl(HTML::FromText) = 2.05
Requires: /usr/bin/perl perl(Email::Find::addrspec) perl(Exporter::Lite) perl(HTML::Entities) perl(HTML::FromText) perl(Scalar::Util) perl(Text::Tabs) perl(strict) perl(vars)


APPROVED.

Comment 8 Nicolas Chauvet (kwizart) 2008-09-04 16:17:20 UTC
New Package CVS Request
=======================
Package Name: perl-HTML-FromText
Short Description: Convert plain text to HTML
Owners: kwizart
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes

Comment 9 Kevin Fenzi 2008-09-05 16:51:39 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.