Spec URL: http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText-2.05-1.fc8.kwizart.src.rpm Description: Convert plain text to HTML
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=766986 + rpmlint is silent for SRPM and for RPM. + source files match upstream url fb8ae4ab0cae0b57101f78b046b3927b HTML-FromText-2.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave + Package
oops koji build failed. Thought this is base package. Need to review then bug 458080 first.
did you asked upstream to fix tests that are failing? rpmlint reported perl-HTML-FromText.noarch: E: non-standard-executable-perm /usr/bin/text2html 0555 ==> you need to add following line to %build %{_fixperms} $RPM_BUILD_ROOT/*
ping?
ping again Can you fix issues given in comment #3?
Spec URL: http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-HTML-FromText-2.05-2.fc8.kwizart.src.rpm Description: Convert plain text to HTML Changelog - Add fixperms Mail sent today to report the problem at make test.
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=806666 + rpmlint is silent for SRPM and for RPM. + source files match upstream url fb8ae4ab0cae0b57101f78b046b3927b HTML-FromText-2.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=13, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.21 cusr 0.02 csys = 0.26 CPU) + Package perl-HTML-FromText-2.05-2.fc10 => Provides: perl(HTML::FromText) = 2.05 Requires: /usr/bin/perl perl(Email::Find::addrspec) perl(Exporter::Lite) perl(HTML::Entities) perl(HTML::FromText) perl(Scalar::Util) perl(Text::Tabs) perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-HTML-FromText Short Description: Convert plain text to HTML Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes
cvs done.