Bug 458455 - rhpl should use $(MAKE), not make
rhpl should use $(MAKE), not make
Status: CLOSED NEXTRELEASE
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: rhpl (Show other bugs)
5.4
All Linux
medium Severity medium
: rc
: ---
Assigned To: Anaconda Maintenance Team
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-08 11:27 EDT by Will Murnane
Modified: 2008-08-11 13:19 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-08-11 13:19:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Will Murnane 2008-08-08 11:27:28 EDT
Description of problem:
I'm trying to compile rhpl on another platform, and it uses a non-GNU make.  Using gmake fixes this, but the Makefile explicitly specifies 'make' rather than the traditional $(MAKE).  A patch is included below.

Version-Release number of selected component (if applicable):
0.216

How reproducible:
always

Steps to Reproduce:
1. run make
2. it fails
  
Actual results:


Expected results:


Additional info:
diff -ru rhpl-0.216/Makefile rhpl-0.216-mod//Makefile
--- rhpl-0.216/Makefile Fri Jun 13 11:07:58 2008
+++ rhpl-0.216-mod//Makefile    Fri Aug  8 11:03:02 2008
@@ -14,16 +14,16 @@
 all: subdirs

 subdirs:
-       for d in $(SUBDIRS); do make -C $$d; [ $$? = 0 ] || exit 1; done
+       for d in $(SUBDIRS); do $(MAKE) -C $$d; [ $$? = 0 ] || exit 1; done

 clean:
-       for d in $(SUBDIRS); do make -C $$d clean; done
+       for d in $(SUBDIRS); do $(MAKE) -C $$d clean; done
        rm -f *.o *.so *.lo *.a *.pyc

 install: all
        mkdir -p $(DESTDIR)/$(PYDIR)

-       for d in $(SUBDIRS); do make -C $$d install; done
+       for d in $(SUBDIRS); do $(MAKE) -C $$d install; done

        $(PYTHON) -c "import compileall; compileall.compile_dir('$(DESTDIR)/$(PYDIR)', 3, '$(PYDIR)', 1)"
Comment 1 Chris Lumens 2008-08-11 13:19:27 EDT
This will be fixed in the next build of rhpl for Rawhide, and therefore the next major release of RHEL.  If you need this fixed in an update release of RHEL5, please talk to your support representative who will raise this issue through the appropriate channels.  Thanks.

Note You need to log in before you can comment on or make changes to this bug.