Red Hat Bugzilla – Bug 458660
Review Request: perl-Graph-Easy
Last modified: 2008-10-03 02:11:41 EDT
Graph::Easy lets you generate graphs consisting of various shaped nodes
connected by edges (with optional labels).
Could someone double check the licence?
Marcela -- is someone reviewing this? The fedora-review flag is set to "?", which should indicate a review is in process, but no one is assigned to it... If no one is working it, the flag should be unset so people (like me ;)) know they can review :)
Argh, you're right. I overlooked this in guidelines :(
You can take it.
We're having a problem:
perl-Graph-Easy and perl-Graph-Easy-As_svg have circular build- and run-time dependencies.
AFAIS, at least the circular build-dependency can be resolved by removing BuildRequires: perl-Graph-Easy-As_svg
I know we use in some packages cyclic dependencies. But here should be ok to remove them.
(In reply to comment #4)
> I know we use in some packages cyclic dependencies.
> But here should be ok to remove them.
Resolving the cyclic build-dep is a MUSTFIX, otherwise you won't be able to bootstrap this package.
Afterwards, once this package in Fedora, and when it's being built incrementally, cyclic deps are tolerable. (The normal way to circumvent such issues is add build-conditionals (use %_with_*/%_without_* inside of the *.spec to support rpmbuild --with/--without)
In any case you should file a bug upstream. It's an upstream design flaw.
> Resolving the cyclic build-dep is a MUSTFIX, otherwise you won't be able to
> bootstrap this package.
Yeah, that's obvious.
> In any case you should file a bug upstream. It's an upstream design flaw.
In Makefile.PL is Graph::Easy::As_svg only _recommend_, so there's no need to file a bug.
Is there an updated package for review?
I'll go ahead and fix up the dependencies so that this ticket shows up in the review queue and Graph::Easy::As_svg depends on it.
Well, this package was needed and maybe will be needed again for Padre. Could we close it, when we don't need it at this moment?
If it's no longer needed, obviously you can close the review ticket and anything which depends on it. Its up to you, and there is certainly no shortage of packages for me to review.