Spec URL: http://www.auroralinux.org/people/spot/review/new/pidgin-facebookchat.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/pidgin-facebookchat-1.33-1.fc10.src.rpm Description: This is a Facebook chat plugin for Pidgin and libpurple messengers. It connects to the new Facebook Chat IM service without the need for an API key. Currently the plugin can log into the Facebook servers, grab the buddy list, send/receive messages, add/remove friends, receive notifications, search for Facebook friends and set your Facebook status.
I will do this review shortly.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistent macro usage. OK - Meets Packaging Guidelines. - License field in spec matches - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint error/warnings Preliminary check shows package is functional. Suggestion: Might include the icons from http://pidgin-facebookchat.googlecode.com/files/facebook_icons.zip APPROVED
New Package CVS Request ======================= Package Name: pidgin-facebook Short Description: Facebook Chat IM Pidgin plugin Owners: spot Branches: F-8 F-9 devel InitialCC: .... and its done.
pidgin-facebookchat-1.35-2.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/pidgin-facebookchat-1.35-2.fc8
pidgin-facebookchat-1.35-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/pidgin-facebookchat-1.35-2.fc9
Built in rawhide.
pidgin-facebookchat-1.35-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
pidgin-facebookchat-1.35-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.