Bug 459064 - Review Request: hyphen-ga - Irish hyphenation rules
Summary: Review Request: hyphen-ga - Irish hyphenation rules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-14 07:22 UTC by Caolan McNamara
Modified: 2008-08-23 18:59 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-08-23 18:59:15 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2008-08-14 07:22:02 UTC
Spec URL: http://people.redhat.com/caolanm/hunspell/hyphen-ga.spec
SRPM URL: http://people.redhat.com/caolanm/hunspell/hyphen-ga-0.20040220-1.fc9.src.rpm
Description: Irish hyphenation rules as used by libhyphen. Enables optimal hyphenation of Irish in OpenOffice.org

Comment 1 Caolan McNamara 2008-08-14 07:23:24 UTC
rpmlint /usr/src/redhat/RPMS/noarch/hyphen-ga-0.20040220-1.fc9.noarch.rpm /usr/src/redhat/SRPMS/hyphen-ga-0.20040220-1.fc9.src.rpm 

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 2 Parag AN(पराग) 2008-08-14 07:54:33 UTC
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=777087
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
bd410dd925853de0dc7e5e117ac2555d  hyph_ga_IE.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text NOT is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

SHOULD:
   Ask upstream to include license text file in next upstream release.

APPROVED.

Comment 3 Caolan McNamara 2008-08-14 08:07:25 UTC
New Package CVS Request
=======================
Package Name: hyphen-ga
Short Description: Irish Hyphenation Rules
Owners: caolanm
Branches: 
InitialCC: 
Packager Commits: yes

Comment 4 Kevin Fenzi 2008-08-23 17:37:55 UTC
cvs done.

Comment 5 Caolan McNamara 2008-08-23 18:59:15 UTC
thanks guys


Note You need to log in before you can comment on or make changes to this bug.