Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.7-2.svn9.fc9.src.rpm Description: iok is Indic Onscreen Keyboard. This package gives virtual Keyboard functionality. It currently works with Inscript keymaps for Indian languages. iok can even try to parse non-inscript keymaps and show them in iok.
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=777244
updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.7-3.svn9.fc9.src.rpm %changelog * Thu Aug 14 2008 Parag Nemade <panemade>- 1.0.7-3.svn9 - fix directory ownership
Thanks for the submission. :) I did some testing. And here are some comments and thoughts: - really like the compact size now - it seems to segfault when loading some maps, which is not nice (would be nice if it only displayed the dialog for those cases) - would be nice to have a toggle button between English and native input - I think it would be better to hide the menu bar (at least the Save and modify entries by default)
(BTW how about using "make dist" to generate the tarballs?) Otherwise the package looks pretty fine to me.
Jens, Thanks for your suggestions. Here is updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-1.fc9.src.rpm Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=799289
smalls things but better to use %configure if possible. :)
updated SPEC and SRPM at same location. Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-1.fc9.src.rpm I don't think I should increase release for such minor change.
Thanks. Here is the review: +:ok, =:needs attention MUST Items: [+] MUST: rpmlint must be run on every package. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name} [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [=] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. 2bd14a41a710f8c91fd994df6322d748 iok-1.0.8.tar.gz - Please provide the URL to the source tarball. [+] MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section [+] MUST: Each package must consistently use macros [+] MUST: The package must contain code, or permissable content. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: The reviewer should test that the package builds in mock. [+] SHOULD: The reviewer should test that the package functions as described. Package is APPROVED, after adding the missing source url.
Created attachment 315721 [details] iok.spec-1.patch suggestion for improving the description
Jens, Thanks for your suggestions. Here is updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-2.fc9.src.rpm Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=805828
New Package CVS Request ======================= Package Name: iok Short Description: Indic onscreen virtual keyboard Owners: pnemade Branches: F-9 InitialCC: petersen
cvs admin done
Package Change Request ====================== Package Name: iok New Branches: EL-5
added
Jens, Thanks for review and cvs.
iok-1.0.8-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/iok-1.0.8-2.fc9
requested by Jens Petersen (#27995)
iok-1.0.8-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.