Spec URL: http://people.redhat.com/caolanm/hunspell/hyphen-sv.spec SRPM URL: http://people.redhat.com/caolanm/hunspell/hyphen-sv-0.20030814-1.fc9.src.rpm Description: hyphen-sv : Swedish Hyphenation Rules as used by libhyphen, used by OOo to hyphenate words.
picking this for review. koji scratch build is giving timed out. will do review tomorrow.
Koji still giving problem. This is simple package so I will directly review this. Review: + package builds in mock. + rpmlint is silent for SRPM and for RPM. + source files match upstream. a1c31b48cbf570bb05f22e98dacb9e17 hyph_sv_SE.zip + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: hyphen-sv Short Description: Swedish hyphenation rules Owners: caolanm Branches: InitialCC: caolanm
cvs done.
thanks guys