Bug 459198 - Review Request: prelude-notify - Prelude Notification Applet
Review Request: prelude-notify - Prelude Notification Applet
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Peter Vrabec
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-14 17:44 EDT by Steve Grubb
Modified: 2008-08-25 18:21 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-08-25 18:21:26 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
pvrabec: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Steve Grubb 2008-08-14 17:44:44 EDT
Spec URL: http://people.redhat.com/sgrubb/files/prelude-notify.spec

SRPM URL: http://people.redhat.com/sgrubb/files/prelude-notify-0.9-0.1.svn10860.fc9.src.rpm

Description: 

Prelude-notify is a desktop oriented application that works as a
monitoring tool that capture events from prelude manager using the
prelude connection pool event checker. Its purpose is to help security
managers and/or administrators to see in real time what's going on in
their network.

This is a svn snapshot with the final release occurring in the next day or two. I'm using svn snapshot just to get through packaging review and will switch over to release at the first opportunity. In order to run it, you need to be using libprelude from rawhide.
Comment 1 Peter Vrabec 2008-08-15 07:08:48 EDT
OK: rpmlint prelude-notify-0.9-0.1.svn10860.fc9.src.rpm
NOT OK: rpmlint  /home/pvrabec/RPM/RPMS/i386/prelude-notify-
0.9-0.1.svn10860.fc9.i386.rpm

prelude-notify.i386: W: incoherent-version-in-changelog 0.1.svn10860 0.9-0.1.svn10860.fc9
prelude-notify.i386: E: no-binary

- shouldn't it be marked as noarch?

NOT OK: Package Naming Guidelines

- add COPYING and AUTHORS file
- install desktop file by desktop-file-install

OK: Licensing Guidelines
OK: License field in the package spec file
OK: American English
OK: spec file for the package MUST be legible
OK: The sources match the upstream source
OK: successfully compile
OK: ExcludeArch
OK: BuildRequires
OK: locales
OK: shared library files
OK: Prefix: /usr
OK: own all directories
OK: duplicate files in the %files
OK: Permissions on files
OK: clean section
OK: macros
OK: documentation files
OK: %doc, it must not affect the runtime of the application
OK: Header files must be in a -devel package
OK: Static libraries must be in a -static package
OK: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' 
OK: library files with a suffix
OK: fully versioned dependency
OK: Packages must NOT contain any .la libtool archives
OK: GUI applications must include a %{name}.desktop
OK: not own files or directories already owned by other packages
OK: package MUST run rm -rf %{buildroot}
OK: valid UTF-8
Comment 2 Steve Grubb 2008-08-15 09:20:07 EDT
Ok, new packages uploaded. The srpm changed names. You can find it here:

http://people.redhat.com/sgrubb/files/prelude-notify-0.9-0.1.20080814svn10860.fc9.src.rpm

I think this addresses everything above. Note that the svn stuff is only until there is a release which is due today or next week. After that I won't be taking svn snaps. :)

Thanks.
Comment 3 Peter Vrabec 2008-08-15 10:27:33 EDT
package approved
Comment 4 Steve Grubb 2008-08-15 10:44:03 EDT
New Package CVS Request
=======================
Package Name: prelude-notify
Short Description: Prelude Notification Applet
Owners: sgrubb
Branches: F-9
InitialCC:
Cvsextras Commits: no

I suppose uberpackagers would be OK for cvsextras commits. This is a security package. TIA.
Comment 5 Jason Tibbitts 2008-08-15 12:12:00 EDT
Erm, sorry, I must have errantly clicked something.
Comment 6 Kevin Fenzi 2008-08-23 13:41:00 EDT
cvs done.
Comment 7 Steve Grubb 2008-08-25 18:21:26 EDT
Package was imported and built. Closing. Thanks everyone.

Note You need to log in before you can comment on or make changes to this bug.