Bug 459212 - Review Request: oolite-data - Data files for Oolite
Review Request: oolite-data - Data files for Oolite
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: manuel wolfshant
Fedora Extras Quality Assurance
:
Depends On: 459211
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-14 21:27 EDT by Michel Alexandre Salim
Modified: 2009-09-25 03:42 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-09-25 03:42:41 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
wolfy: fedora‑review?


Attachments (Terms of Use)

  None (edit)
Comment 1 manuel wolfshant 2008-12-05 19:02:40 EST
Nothing much to review here, as it's just a bunch of data...
GOOD:
====
SHA1sum corresponds with upstream
  c322fa81a57d39e150806917cb052bb370efa725 oolite-1.65-data.tar.gz
license is OK ( GPLv2+ )
builds fine in mock 

Potential problems
==================
rpmlint output:
Source RPM:
oolite-data.src:32: E: hardcoded-library-path in %{_prefix}/lib/GNUstep/Applications/oolite.app/Contents
oolite-data.src:33: E: hardcoded-library-path in %{_prefix}/lib/GNUstep/Applications/oolite.app/Contents/
oolite-data.src:43: E: hardcoded-library-path in %{_prefix}/lib/GNUstep/Applications/oolite.app/Contents/Resources/*
--> What is the are these required by the game or

oolite-data.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 12)
1 packages and 0 specfiles checked; 3 errors, 1 warnings.
--> esthetic bug, please fix before commit

rpmlint of oolite-data:
oolite-data.noarch: E: only-non-binary-in-usr-lib
--> normal, as we have just data

MUSTFIX
=======
the folders below /usr/lib/GNUstep/Applications/oolite.app/ seem to be left unowned and at the first glance oolite does not own them either.
Comment 2 Michel Alexandre Salim 2009-09-25 03:42:41 EDT
Closing this bug, as upstream has merged oolite and oolite-data

Note You need to log in before you can comment on or make changes to this bug.