Bug 459218 - Review Request: python-morph - Image Morphology Toolbox
Review Request: python-morph - Image Morphology Toolbox
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-08-14 22:53 EDT by kushaldas@gmail.com
Modified: 2008-10-07 11:13 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-10-07 11:13:25 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description kushaldas@gmail.com 2008-08-14 22:53:16 EDT
Spec URL: http://kushal.fedorapeople.org/packages/python-morph.spec
SRPM URL: http://kushal.fedorapeople.org/packages/python-morph-0.89-1.fc9.src.rpm
Description: The image morphology toolbox implements the basic binary and grayscale morphology operations, working with numpy arrays to hold image data.
Comment 1 Jason Tibbitts 2008-08-16 10:33:53 EDT
This package is clean, but I believe it is improperly named.  I can't get to the wiki to look at the guidelines right now, so I'll just skip the bits about naming in the review.  I'm thinking that either "pymorph" or "python-pymorph" would be proper names under the guidelines, but since you don't "import morph", I don't believe it should be named just "python-morph".

It looks like 0.90 was released at about the same time you submitted this ticket.  I don't see anything in the new version that would affect this review, but if you'd like for me to look over an updated package then I will.

I tried to test this by running "python morphdemo.py" with the package installed, but I only get:

/usr/lib/python2.5/site-packages/pymorph/compat.py:489: Warning: 'with' will become a reserved keyword in Python 2.6
Traceback (most recent call last):
  File "../../morphdemo.py", line 39, in <module>
    from pymorph.compat import *
  File "/usr/lib/python2.5/site-packages/pymorph/compat.py", line 507
    def mmcwatershed(f,Bc=None,linereg='LINES'):
SyntaxError: invalid syntax

I'm not sufficiently familiar with python to understand what's happening.

* source files match upstream:
* specfile is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package (in README file).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   python-morph = 0.89-1.fc10
   python(abi) = 2.5

? Manual tests seem to fail.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Comment 2 Jason Tibbitts 2008-10-01 12:20:37 EDT
Anything happening here?
Comment 3 Jason Tibbitts 2008-10-07 11:13:25 EDT
No response; closing.

Note You need to log in before you can comment on or make changes to this bug.