Red Hat Bugzilla – Bug 459218
Review Request: python-morph - Image Morphology Toolbox
Last modified: 2008-10-07 11:13:25 EDT
Spec URL: http://kushal.fedorapeople.org/packages/python-morph.spec SRPM URL: http://kushal.fedorapeople.org/packages/python-morph-0.89-1.fc9.src.rpm Description: The image morphology toolbox implements the basic binary and grayscale morphology operations, working with numpy arrays to hold image data.
This package is clean, but I believe it is improperly named. I can't get to the wiki to look at the guidelines right now, so I'll just skip the bits about naming in the review. I'm thinking that either "pymorph" or "python-pymorph" would be proper names under the guidelines, but since you don't "import morph", I don't believe it should be named just "python-morph". It looks like 0.90 was released at about the same time you submitted this ticket. I don't see anything in the new version that would affect this review, but if you'd like for me to look over an updated package then I will. I tried to test this by running "python morphdemo.py" with the package installed, but I only get: /usr/lib/python2.5/site-packages/pymorph/compat.py:489: Warning: 'with' will become a reserved keyword in Python 2.6 Traceback (most recent call last): File "../../morphdemo.py", line 39, in <module> from pymorph.compat import * File "/usr/lib/python2.5/site-packages/pymorph/compat.py", line 507 def mmcwatershed(f,Bc=None,linereg='LINES'): ^ SyntaxError: invalid syntax I'm not sufficiently familiar with python to understand what's happening. * source files match upstream: 2bcd2d061fc539af983bfec221a99cff2a9c9389a1615a6fab471b40864cd935 pymorph-0.89.tar.gz * specfile is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package (in README file). * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: python-morph = 0.89-1.fc10 = numpy python(abi) = 2.5 ? Manual tests seem to fail. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Anything happening here?
No response; closing.