Red Hat Bugzilla – Bug 459219
Review Request: ibus-chewing - Chewing engine for IBus
Last modified: 2008-08-24 18:52:49 EDT
Spec URL: http://ibus.googlecode.com/files/ibus-chewing.spec SRPM URL: http://ibus.googlecode.com/files/ibus-chewing-0.1.1.20080815-1.fc9.src.rpm Description: Chewing engine for IBus
koji is down currently. will review this later on.
http://koji.fedoraproject.org/koji/taskinfo?taskID=778101 rpmlint is clean will review on Monday.
Review: + package builds in mock (rawhide i386). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=778101 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7a9351ff7a9cb4bfa533ea657aec648c ibus-chewing-0.1.1.20080815.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package ibus-chewing-0.1.1.20080815-1.fc10 Provides: _chewing.so Requires: /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.8) libchewing.so.3 python(abi) = 2.5 rtld(GNU_HASH) Suggestions:- Use make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install to preserve timestamps for files(like .py and .png) copied from tarball to rpm APPROVED.
New Package CVS Request ======================= Package Name: ibus-chewing Short Description: The Chewing input engine for IBus platform Owners: phuang Branches: F-9 EL-5 InitialCC: phuang Cvsextras Commits: yes
cvs done.
built it. Thanks for Kevin & Parag.