Bug 459219 - Review Request: ibus-chewing - Chewing engine for IBus
Summary: Review Request: ibus-chewing - Chewing engine for IBus
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-15 04:23 UTC by Peng Huang
Modified: 2008-08-24 22:52 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-08-24 22:52:49 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Peng Huang 2008-08-15 04:23:52 UTC
Spec URL: http://ibus.googlecode.com/files/ibus-chewing.spec
SRPM URL: http://ibus.googlecode.com/files/ibus-chewing-0.1.1.20080815-1.fc9.src.rpm
Description: Chewing engine for IBus

Comment 1 Parag AN(पराग) 2008-08-15 10:22:41 UTC
koji is down currently. will review this later on.

Comment 2 Parag AN(पराग) 2008-08-22 15:56:39 UTC
http://koji.fedoraproject.org/koji/taskinfo?taskID=778101
rpmlint is clean 
will review on Monday.

Comment 3 Parag AN(पराग) 2008-08-23 15:00:23 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=778101
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7a9351ff7a9cb4bfa533ea657aec648c  ibus-chewing-0.1.1.20080815.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are correct
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package ibus-chewing-0.1.1.20080815-1.fc10
Provides: _chewing.so
Requires: /bin/sh libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
 libc.so.6(GLIBC_2.8) libchewing.so.3 python(abi) = 2.5 rtld(GNU_HASH)

Suggestions:-
  Use make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install to preserve
timestamps for files(like .py and .png) copied from tarball to rpm 

APPROVED.

Comment 4 Peng Huang 2008-08-23 23:26:56 UTC
New Package CVS Request
=======================
Package Name: ibus-chewing
Short Description: The Chewing input engine for IBus platform
Owners: phuang
Branches: F-9 EL-5
InitialCC: phuang
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-08-24 18:57:39 UTC
cvs done.

Comment 6 Peng Huang 2008-08-24 22:52:49 UTC
built it.
Thanks for Kevin & Parag.


Note You need to log in before you can comment on or make changes to this bug.