Bug 459527 - Performance degradation due to excessive spinlocking in the block layer when using logical volume that spans too many physical volumes
Summary: Performance degradation due to excessive spinlocking in the block layer when ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Mikuláš Patočka
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-19 18:21 UTC by Mikuláš Patočka
Modified: 2009-01-20 20:17 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-01-20 20:17:19 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
a patch for the problem (1.61 KB, patch)
2008-08-19 21:07 UTC, Mikuláš Patočka
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:0225 0 normal SHIPPED_LIVE Important: Red Hat Enterprise Linux 5.3 kernel security and bug fix update 2009-01-20 16:06:24 UTC

Description Mikuláš Patočka 2008-08-19 18:21:11 UTC
I'm creating this bugzilla to track the integration of the patch into RHEL 5.

Mike Anderson was doing an OLTP benchmark on a computer with 48 physical
disks mapped to one logical device via device mapper.

He found that there was a slowdown on request_queue->lock in function
generic_unplug_device. The slowdown is caused by the fact that when some
code calls unplug on the device mapper, device mapper calls unplug on all
physical disks. These unplug calls take the spinlock, find that the queue is
already unplugged, release the spinlock and exit.

The test for already unplugged queue can be moved out of the spinlock.
When it was done, there was 18% performance improvement on the whole
benchmark.

Comment 1 Mikuláš Patočka 2008-08-19 21:07:48 UTC
Created attachment 314574 [details]
a patch for the problem

A patch for the problem. Test for already unplugged queue outside the spinlock.

Comment 3 Don Zickus 2008-09-10 20:14:56 UTC
in kernel-2.6.18-110.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 errata-xmlrpc 2009-01-20 20:17:19 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html


Note You need to log in before you can comment on or make changes to this bug.