Bug 459875 - e2fsck finds invalid group descriptor checksums every boot
Summary: e2fsck finds invalid group descriptor checksums every boot
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: e2fsprogs
Version: 9
Hardware: i686
OS: Linux
medium
high
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-08-23 11:28 UTC by Kornienko Sergey
Modified: 2008-10-01 06:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-01 06:39:22 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Debian BTS 490637 0 None None None Never

Description Kornienko Sergey 2008-08-23 11:28:04 UTC
Package: e2fsprogs
Version: 1.41.0-1
RPM: e2fsprogs-1.41.0-1.fc9.i386

After upgrading e2fsprogs to version 1.41.0-1, e2fsck runs at every
boot, reporting the following errors:

Group descriptor 1551 checksum is invalid.  FIXED.
Group descriptor 1552 checksum is invalid.  FIXED.
Group descriptor 1553 checksum is invalid.  FIXED.
...
Group descriptor 1560 checksum is invalid.  FIXED.

No such problems with previous version e2fsprogs 1.40.8.
The home filesystem is ext3 on HDD.
If I boot LiveCD in rescue mode and check this filesystem no any errors was found.

[root@den ~]# tune2fs -l /dev/sda5
tune2fs 1.41.0 (10-Jul-2008)
Filesystem volume name:   /home
Last mounted on:          <not available>
Filesystem UUID:          b66674f8-5b30-4d12-b747-b9e4ffea335f
Filesystem magic number:  0xEF53
Filesystem revision #:    1 (dynamic)
Filesystem features:      has_journal ext_attr dir_index filetype needs_recovery sparse_super large_file
Filesystem flags:         signed_directory_hash
Default mount options:    (none)
Filesystem state:         clean
Errors behavior:          Continue
Filesystem OS type:       Linux
Inode count:              27836416
Block count:              55671241
Reserved block count:     0
Free blocks:              284411
Free inodes:              27630202
First block:              0
Block size:               4096
Fragment size:            4096
Blocks per group:         32768
Fragments per group:      32768
Inodes per group:         16384
Inode blocks per group:   512
Filesystem created:       Fri Oct 27 21:14:14 2006
Last mount time:          Sat Aug 23 12:11:20 2008
Last write time:          Sat Aug 23 12:11:20 2008
Mount count:              1
Maximum mount count:      48
Last checked:             Sat Aug 23 12:01:06 2008
Check interval:           15552000 (6 months)
Next check after:         Thu Feb 19 11:01:06 2009
Reserved blocks uid:      0 (user root)
Reserved blocks gid:      0 (group root)
First inode:              11
Inode size:               128
Journal inode:            8
Default directory hash:   tea
Directory Hash Seed:      aca86e48-09dd-4201-90b2-3a952c943ec1
Journal backup:           inode blocks

[root@den ~]# uname -a
Linux den 2.6.25.14-108.fc9.i686 #1 SMP Mon Aug 4 14:08:11 EDT 2008 i686 athlon i386 GNU/Linux

I found similar problem in Debian Bug Tracking System with number 490637.
Possible resolve this problem.


Copy from Debian BTS:

Thanks for reporting this bug.  I will shortly be releasing a fixed
e2fsprogs with this patch.

                                                - Ted

>From 4729455f0a68f2fa0a83ec8460d1d4bccba9dcfa Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <[EMAIL PROTECTED]>
Date: Sun, 13 Jul 2008 19:03:59 -0400
Subject: [PATCH] libext2fs: Don't check the group checksum when !GDT_CSUM

ext2fs_group_desc_csum_verify() is always checking the bg_checksum (to
make sure it is zero) even when the GDT_CSUM feature is not present.
This is normally OK, but apparently there are filesystems in the wild
where this field has not be initialized to zero.

Addresses-Debian-Bug: #490637

Signed-off-by: "Theodore Ts'o" <[EMAIL PROTECTED]>
---
 lib/ext2fs/csum.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/ext2fs/csum.c b/lib/ext2fs/csum.c
index ce1508e..6a49d8f 100644
--- a/lib/ext2fs/csum.c
+++ b/lib/ext2fs/csum.c
@@ -60,8 +60,10 @@ STATIC __u16 ext2fs_group_desc_csum(ext2_filsys fs, dgrp_t 
group)
 
 int ext2fs_group_desc_csum_verify(ext2_filsys fs, dgrp_t group)
 {
-       if (fs->group_desc[group].bg_checksum != 
-           ext2fs_group_desc_csum(fs, group))
+       if (EXT2_HAS_RO_COMPAT_FEATURE(fs->super,
+                                      EXT4_FEATURE_RO_COMPAT_GDT_CSUM) &&
+           (fs->group_desc[group].bg_checksum != 
+            ext2fs_group_desc_csum(fs, group)))
                return 0;
 
        return 1;
-- 
1.5.6.1.205.ge2c7.dirty

Comment 1 Eric Sandeen 2008-08-23 15:21:34 UTC
Thanks for testing, reporting, and researching!  I'll put that fix into -testing & respin for F9-testing shortly.

-Eric

Comment 2 Fedora Update System 2008-08-23 16:18:02 UTC
e2fsprogs-1.41.0-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/e2fsprogs-1.41.0-2.fc9

Comment 3 Kornienko Sergey 2008-08-23 19:52:24 UTC
Thanks for rapid fixing this problem ! :)

Comment 4 Eric Sandeen 2008-08-24 03:52:48 UTC
You're welcome; nice bug reports with pointers to upstream fixes make it easy :)

Comment 5 Fedora Update System 2008-09-10 07:02:28 UTC
e2fsprogs-1.41.0-2.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update e2fsprogs'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-7360

Comment 6 Fedora Update System 2008-10-01 06:39:20 UTC
e2fsprogs-1.41.0-2.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.