Spec URL: http://www.freedink.org/snapshots/fedora/dink-data.spec SRPM URL: http://www.freedink.org/snapshots/fedora/dink-data-1.08-1.fc8.src.rpm Description: Adventure and role-playing game (game data) Dink Smallwood is an adventure/role-playing game, similar to Zelda, made by RTsoft. Besides twisted humour, it includes the actual game editor, allowing players to create hundreds of new adventures called Dink Modules or D-Mods for short. This package contains architecture-independent data for the original game (except for non-free sounds).
Some notes for 1.08-1: * %setup - %setup is missing, which may cause some strange build failure like the following thread: http://www.redhat.com/archives/rhl-devel-list/2008-February/thread.html#01956 Add "%setup -q -c -T", for example. * Macros - Use macros for standard directories: https://fedoraproject.org/wiki/Packaging/RPMMacros For example, /usr/share must be %{_datadir}. * Output when unpackaging archive - Suppress the output when unpackging archive by "unzip -qq". When you "unzip"s zip archive at %setup, setup uses "-qq" option by default.
ping?
Hi, New package: http://www.freedink.org/snapshots/fedora/freedink-data.spec http://www.freedink.org/snapshots/fedora/freedink-data-1.08.20080914-1.fc8.src.rpm Legal: the Contribution is freedink-data.spec only. Note: I had implemented your suggestions for the previous package here http://git.savannah.gnu.org/gitweb/?p=freedink/dink-data.git;a=blobdiff;f=fedora/dink-data.spec;h=d4dcb9222ecc623c556ad923f00427ef22a97143;hp=b0239669600ccd25229a75127ae8572716024530;hb=de96ae8b8b8f54af63e331e65b017a6c9185d3fb;hpb=daffcc23290b81ee6af253926013332ced7bbc84 but the package changed a lot and this isn't used anymore.
Hi, Here's the new release: http://www.freedink.org/snapshots/fedora/freedink-data.spec http://www.freedink.org/snapshots/fedora/freedink-data-1.08.20080920-1.fc8.src.rpm
For 1.08.20080920-1: * Licensing - Well, from texts about licensing in source tarball all the contents in the tarball are free. However now the tag "License: zlib" (only) is no longer valid as some more files are added as written in README-REPLACEMENTS.txt. * Please check README.txt, README-REPLACEMENTS.txt and update License tag. Also please refer to the below. - About the kind of tags used on Fedora licensing: https://fedoraproject.org/wiki/Licensing - About how to write the tag of License for source tarball containing contents under different licenses: https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License:_field * Also adding files under licenses/ to %doc is necessary. * Macros - Use macros for standard directories: https://fedoraproject.org/wiki/Packaging/RPMMacros /usr must be %{_prefix}. * Timestamps - As this package installs many files in the source tarball as they are, keeping timestamps on those files is strongly recommended. Please replace "cp -r" in Makefile to "cp -pr" or "cp -a". * General rpmlint issue --------------------------------------------------------------- W: wrong-file-end-of-line-encoding /usr/share/doc/freedink-data-1.08.20080920/README-REPLACEMENTS.txt W: wrong-file-end-of-line-encoding /usr/share/doc/freedink-data-1.08.20080920/README.txt --------------------------------------------------------------- - These files have CRLF line terminators, remove them (sed -e 's|\r||' or dos2unix will do this). https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding
(In reply to comment #5) > For 1.08.20080920-1: > > * Licensing > - Well, from texts about licensing in source tarball all the > contents in the tarball are free. > > However now the tag "License: zlib" (only) is no longer valid > as some more files are added as written in README-REPLACEMENTS.txt. OK, should be good now: License: zlib and CC-BY-SA and (GPLv3+ or Free Art or CC-BY-SA) and OAL and Public Domain and CC-BY and GPLv2+ > * Also adding files under licenses/ to %doc is necessary. Is it OK to add the "licenses/" directory directly? > * Macros > - Use macros for standard directories: > https://fedoraproject.org/wiki/Packaging/RPMMacros > /usr must be %{_prefix}. I missed that one. > * Timestamps > - As this package installs many files in the source tarball as they > are, keeping timestamps on those files is strongly recommended. > Please replace "cp -r" in Makefile to "cp -pr" or "cp -a". Fixed in GIT and applied as a patch to avoid a new 56M release. > * General rpmlint issue > --------------------------------------------------------------- > W: wrong-file-end-of-line-encoding > /usr/share/doc/freedink-data-1.08.20080920/README-REPLACEMENTS.txt > W: wrong-file-end-of-line-encoding > /usr/share/doc/freedink-data-1.08.20080920/README.txt > --------------------------------------------------------------- > - These files have CRLF line terminators, remove them > (sed -e 's|\r||' or dos2unix will do this). > > https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding OK, done. Here are the new files: http://www.freedink.org/snapshots/fedora-review/freedink-data.spec http://www.freedink.org/snapshots/fedora-review/freedink-data-1.08.20080920-1.fc8.src.rpm
Please change the release number every time you modify your spec file to avoid confusion. https://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes
Also please write in %changelog what you modified even during review request.
http://www.freedink.org/snapshots/fedora-review/freedink-data.spec http://www.freedink.org/snapshots/fedora-review/freedink-data-1.08.20080920-3.fc8.src.rpm
Okay, good. (In reply to comment #6) > * Also adding files under licenses/ to %doc is necessary. > > Is it OK to add the "licenses/" directory directly? - Sure. Now please also fix licenses/oal-1-0-1.txt CRLF line terminators ----------------------------------------------------------------- This package (freedink-data) is APPROVED by mtasaka -----------------------------------------------------------------
(In reply to comment #10) > - Sure. Now please also fix licenses/oal-1-0-1.txt CRLF line terminators Hmm, oal-1-0-1.txt has Unix newlines. I see that art_libre-1.3.html and free_art-1.3.html do, though as they are HTML documents this shouldn't be an issue? > ----------------------------------------------------------------- > This package (freedink-data) is APPROVED by mtasaka > ----------------------------------------------------------------- Yay!
(In reply to comment #11) > (In reply to comment #10) > > - Sure. Now please also fix licenses/oal-1-0-1.txt CRLF line terminators > > Hmm, oal-1-0-1.txt has Unix newlines. Here it seems I was half asleep again :( sorry. > I see that art_libre-1.3.html and free_art-1.3.html do, though as they are HTML > documents this shouldn't be an issue? I guess this can be ignored. Removing NEEDSPONSOR (bug 455916)
New Package CVS Request ======================= Package Name: freedink-data Short Description: Adventure and role-playing game (game data) Owners: beuc Branches: F-8 F-9 InitialCC: beuc
cvs done.
freedink-data-1.08.20080920-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/freedink-data-1.08.20080920-3.fc9
freedink-data-1.08.20080920-3.fc8 has been submitted as an update for Fedora 8. http://admin.fedoraproject.org/updates/freedink-data-1.08.20080920-3.fc8
Thanks. Now closing. When you think the submitted packages can be moved to stable repository, please modify (edit) the request on bodhi.
freedink-data-1.08.20080920-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
freedink-data-1.08.20080920-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.