Bug 459933 (perl-RPC-XML) - Review Request: perl-RPC-XML - Set of classes for core data, message and XML handling
Summary: Review Request: perl-RPC-XML - Set of classes for core data, message and XML ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-RPC-XML
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/RPC-XML/
Whiteboard:
Depends On:
Blocks: 454102
TreeView+ depends on / blocked
 
Reported: 2008-08-24 20:24 UTC by Chris Weyl
Modified: 2014-12-29 16:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-09-08 18:14:17 UTC
Type: ---
Embargoed:
mmaslano: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-08-24 20:24:42 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-RPC-XML-0.60-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-RPC-XML.spec

Description:
The RPC::XML package is an implementation of XML-RPC. The module provides
classes for sample client and server implementations, a server designed as an
Apache location-handler, and a suite of data-manipulation classes that are
used by them.

Comment 1 Chris Weyl 2008-08-24 20:30:39 UTC
Koji task: http://koji.fedoraproject.org/koji/taskinfo?taskID=781962

Comment 2 Marcela Mašláňová 2008-08-25 07:52:22 UTC
Strange thing:
t/40_server..........NOK 9/54
#   Failed test 'RPC::XML::Server::url method (set)'
#   at t/40_server.t line 58.
#          got: 'http://localhost.localdomain:9000/'
#     expected: 'http://localhost:9000/'
t/40_server..........ok 24/54# Looks like you failed 1 test of 54.
t/40_server..........dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 9
        Failed 1/54 tests, 98.15% okay

Is there any reason why this build fail on my computer and run ok in koji?

Comment 3 Marcela Mašláňová 2008-08-25 08:16:28 UTC
- rpmlint checks return: OK
- package meets naming guidelines OK
- package meets packaging guidelines OK
- license, text in %doc, matches source OK
- spec file legible, in am. english - possibly yes
- source matches upstream OK
- package compiles on devel (x86) - comment#1 OK
- no missing BR OK
- no unnecessary BR OK
- no locales OK
- not relocatable OK
- owns all directories that it creates OK
- no duplicate files OK
- permissions ok OK
- %clean ok OK
- macro use consistent OK
- code, not content OK
- no need for -docs OK
- nothing in %doc affects runtime OK
- no need for .desktop file  OK

Comment 4 Chris Weyl 2008-08-25 15:52:27 UTC
(In reply to comment #2)
> Strange thing:
> t/40_server..........NOK 9/54
> #   Failed test 'RPC::XML::Server::url method (set)'
> #   at t/40_server.t line 58.
> #          got: 'http://localhost.localdomain:9000/'
> #     expected: 'http://localhost:9000/'
> t/40_server..........ok 24/54# Looks like you failed 1 test of 54.
> t/40_server..........dubious
>         Test returned status 1 (wstat 256, 0x100)
> DIED. FAILED test 9
>         Failed 1/54 tests, 98.15% okay
> 
> Is there any reason why this build fail on my computer and run ok in koji?

Oddly, I found that that particular test is highly sensitive to the order of hostnames on the loopback line in /etc/hosts.  e.g. it failed on my laptop when the line was:

127.0.0.1 athena localhost localhost.localdomain

But passed just fine when I moved 'athena' to the end of the line.

Comment 5 Jason Tibbitts 2008-08-26 03:50:09 UTC
I would disable the test since it's pretty broken.

Comment 6 Chris Weyl 2008-08-27 03:01:36 UTC
Wrapped it in a TODO. Not ideal, but then, we don't really expect it to consistently work, so...

http://koji.fedoraproject.org/koji/taskinfo?taskID=787971

SRPM URL:
http://fedora.biggerontheinside.net/review/perl-RPC-XML-0.60-2.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-RPC-XML.spec

Comment 7 Marcela Mašláňová 2008-08-29 10:18:33 UTC
I had similar problem with hosts test in perl packages. I thought that's problem of lazy network. Switch off this one test isn't problem for review, but it should be fixed in upstream.

Comment 8 Chris Weyl 2008-09-02 18:49:14 UTC
(In reply to comment #7)
> I had similar problem with hosts test in perl packages. I thought that's
> problem of lazy network. Switch off this one test isn't problem for review, but
> it should be fixed in upstream.

Yah, and reported as such (see http://rt.cpan.org/Public/Bug/Display.html?id=38917 ).

Comment 9 Chris Weyl 2008-09-06 00:06:00 UTC
Heh.  Apparently 'APPROVED' is my Pavlovian trigger...  :-)

Comment 10 Chris Weyl 2008-09-06 00:06:50 UTC
New Package CVS Request
=======================
Package Name: perl-RPC-XML
Short Description: Set of classes for core data, message and XML handling
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

Comment 11 Kevin Fenzi 2008-09-08 15:16:28 UTC
cvs done.

Comment 12 Chris Weyl 2008-09-08 18:14:17 UTC
Imported and built.  Thanks for the review! :-)

Comment 13 Richard Shaw 2013-08-29 12:51:40 UTC
Package Change Request
======================
Package Name: perl-RPC-XML
New Branches: el6
Owners: hobbes1069
InitialCC: 

Needed for fldigi

Comment 14 Gwyn Ciesla 2013-08-29 13:29:37 UTC
Git done (by process-git-requests).

Comment 15 Richard Shaw 2014-12-29 13:46:15 UTC
Package Change Request
======================
Package Name: perl-RPC-XML
New Branches: epel7
Owners: hobbes1069
InitialCC:

Comment 16 Kevin Fenzi 2014-12-29 16:47:05 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.