Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 460103

Summary:	kernel: alsa: asoc: fix double free and memory leak in many codec drivers [rhel-5.3]
Product:	Red Hat Enterprise Linux 5	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	kernel	Assignee:	Jaroslav Kysela <jkysela>
Status:	CLOSED ERRATA	QA Contact:	Martin Jenner <mjenner>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.3	CC:	dzickus, lwang, mgahagan, peterm, syeghiay
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-01-20 20:14:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	460102
Bug Blocks:

Description Eugene Teo (Security Response) 2008-08-26 07:52:14 UTC

+++ This bug was initially created as a clone of Bug #460102 +++

Description of problem:
Many SoC audio codec drivers have improper freeing of memory in error paths.

* codec is allocated in the platform device probe function, but is not freed there in case of error. Instead it is freed in the i2c device probe function's error path. However the success or failure of both functions is not linked, so this could result in a double free (if the platform device is successfully probed, the i2c device probing fails and then the platform driver is unregistered.)

* codec->private_data is allocated in many platform device probe functions but not freed in their error paths.

--- Additional comment from eteo on 2008-08-26 03:44:56 EDT ---

Proposed upstream patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=3051e41ab7daaa59d4564f20b25dcb8c03f35f2b

--- Additional comment from eteo on 2008-08-26 03:45:45 EDT ---

Created an attachment (id=314967)
Upstream patch for this issue

Comment 1 Eugene Teo (Security Response) 2008-08-26 07:53:22 UTC

We need to backport the wm87{31,50}.c bits to the rhel kernel.

Comment 3 RHEL Program Management 2008-08-28 13:53:41 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Don Zickus 2008-09-05 20:07:08 UTC

in kernel-2.6.18-108.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Comment 7 Mike Gahagan 2008-12-09 20:00:36 UTC

Confirmed fix is in the -125 kernel.

Comment 9 errata-xmlrpc 2009-01-20 20:14:03 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-0225.html