Red Hat Bugzilla – Bug 460352
Review Request: xwota - Who's On the Air Database interface
Last modified: 2008-12-11 03:06:44 EST
Spec URL: http://lucilanga.fedorapeople.org/xwota.spec
SRPM URL: http://lucilanga.fedorapeople.org/xwota-0.4-3.fc9.src.rpm
Description: Xwota is intended for amateur radio operators who want to make use of the WOTA database.
It can be used to find out who is on the air, the band and frequency they are
operating on, and their location by country, state, county, grid, and
It's very similar to a DX Cluster client, but it works with the WOTA database
and contains more informations.
If you don't known what is the WOTA database, please read some infos at
It's written in C and GTK, and it works on the latests Linux/BSD distributions
and MAC OS X (with X11 package installed).
added missing desktop/icon file and bumped version
I'm confused about the licensing situation:
The COPYING file contains GPLv2.
Xwota is free and it is published under the GNU GPL Licence.
The source files (that aren't autogenerated by glade) say:
* Copyright Emanuele Madeo IZ0ETE
* Email <firstname.lastname@example.org>
I would guess that the result is GPLv2+, but the fact that the source files are merely copyrighted with no rights given and do not refer to the GPL at all may override the other statements. I guess I'll block FE-Legal; maybe this could get into the FAQ.
So, this should be:
We know that Emanuele Madeo is the author and copyright holder, and README is his statement of licensing intent. However, we have no clear versioning intent (remember, COPYING doesn't reflect versioning intent for GPL), thus GPL+.
We should also strongly recommend that upstream include proper source file license attribution, with versioning intent, on all source files.
So, this package is simple and looks pretty good except for the license tag.
Is there any point to mentioning what operating systems the program works on? Does that even matter for a Fedora package?
I note the following complaint from desktop-file-install:
/builddir/build/BUILDROOT/xwota-0.4-4.fc10.x86_64/usr/share/applications/xwota.desktop: warning: value "xwota.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
So just fix that and the license tag and the desktop file up and this should be ready to go.
Finally, I note that you have submitted 24 packages for review, while you've only reviewed three packages. I will periodically revisit your packages as I work through the queue and I suppose eventually all of them will be reviewed but the reviewers are much more likely to review your packages if you do some more reviews yourself.
* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field needs a fix.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
xwota = 0.4-4.fc10
xwota(x86-64) = 0.4-4.fc10
* %check is not present; no test suite upstream. I don't really know how to use
the program, but I installed it and it seemed to work.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X desktop file elicits a complaint from desktop-file-install.
> Is there any point to mentioning what operating systems the program works on?
> Does that even matter for a Fedora package?
dropped the part.
> I note the following complaint from desktop-file-install:
> warning: value "xwota.png" for key "Icon" in group "Desktop Entry" is an icon
> name with an extension, but there should be no extension as described in the
> Icon Theme Specification if the value is not an absolute path
> So just fix that and the license tag and the desktop file up and this should be
> ready to go.
> Finally, I note that you have submitted 24 packages for review, while you've
> only reviewed three packages. I will periodically revisit your packages as I
> work through the queue and I suppose eventually all of them will be reviewed
> but the reviewers are much more likely to review your packages if you do some
> more reviews yourself.
Looks good. desktop-file-install has been quieted and the license tag is correct now.
Thanks for doing more reviews; it really helps.
New Package CVS Request
Package Name: xwota
Short Description: Who's On the Air Database interface
Branches: F-8 F-9 F-10 EL-5
xwota-0.4-5.fc8 has been submitted as an update for Fedora 8.
xwota-0.4-5.fc9 has been submitted as an update for Fedora 9.
xwota-0.4-5.fc10 has been submitted as an update for Fedora 10.
xwota-0.4-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
xwota-0.4-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
xwota-0.4-5.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.